Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the lq v2 tests #3730

Closed
wants to merge 26 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9d025c0
Rebase
phughk Mar 18, 2024
ba1ed19
Fixup tests and impl
phughk Mar 18, 2024
fe8ddfa
Clippy
phughk Mar 18, 2024
3244aa0
Fixes
phughk Mar 18, 2024
2a1be07
Fixup for list of values
phughk Mar 18, 2024
a77f81e
WIP, versionstamp generator for tests
phughk Mar 18, 2024
23531cf
Add versionstamp generator
phughk Mar 18, 2024
0e6e9f9
Merge remote-tracking branch 'surrealdb/main' into versionstamp-gener…
phughk Mar 18, 2024
7f2986b
Add line, but waiting for decision on how to expose something
phughk Mar 18, 2024
1a1ee88
jazzhands
phughk Mar 18, 2024
faf790e
Fix a test to include the fluid versionstamps
phughk Mar 18, 2024
b768c94
Fixup
phughk Mar 18, 2024
9aa715e
Versionstamp remove limit
phughk Mar 19, 2024
c715e35
Changefeed test fixes
phughk Mar 19, 2024
a544b98
Fixup for some format
phughk Mar 19, 2024
b0a8486
Fixup for lints
phughk Mar 19, 2024
1f8e2e6
Fixup
phughk Mar 19, 2024
861eef8
Lil fixes
phughk Mar 19, 2024
05693a4
Fix
phughk Mar 19, 2024
7ecd255
Merge remote-tracking branch 'surrealdb/main' into versionstamp-gener…
phughk Mar 20, 2024
7a92035
Enable SURREALDB_CHANGE_FEED_LIVE_QUERIES for tests
phughk Mar 20, 2024
8345169
Fix test
phughk Mar 20, 2024
cec16f9
Merge branch 'versionstamp-generator' into fix-the-lq-v2-tests
phughk Mar 20, 2024
c21287d
Merge remote-tracking branch 'surrealdb/main' into fix-the-lq-v2-tests
phughk Mar 21, 2024
bc359eb
Merge remote-tracking branch 'surrealdb/main' into fix-the-lq-v2-tests
phughk Mar 21, 2024
e48be18
Merge remote-tracking branch 'surrealdb/main' into fix-the-lq-v2-tests
phughk Apr 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/fflags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ pub static FFLAGS: FFlags = FFlags {
// TODO(fflag-lqcf): This TODO signature marks tests that are affected by the fflag that do not have access to the fflag (scope)
change_feed_live_queries: FFlagEnabledStatus {
enabled_release: false,
enabled_debug: false,
enabled_test: false,
enabled_debug: true,
enabled_test: true,
env_override: "SURREALDB_CHANGE_FEED_LIVE_QUERIES",
owner: "Hugh Kaznowski",
description: "Disables live queries as a separate feature and moves to using change feeds as the underlying mechanism",
Expand Down
6 changes: 6 additions & 0 deletions core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ pub mod test_helpers {
pub use crate::vs::generate_versionstamp_sequences;
}

#[doc(hidden)]
pub mod test_helpers {
pub use crate::vs::conv::to_u128_be;
pub use crate::vs::generate_versionstamp_sequences;
}

#[doc(hidden)]
/// Channels for receiving a SurrealQL database export
pub mod channel {
Expand Down
1 change: 0 additions & 1 deletion core/src/vs/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ pub fn generate_versionstamp_sequences(start: Versionstamp) -> VersionstampSeque
}

#[doc(hidden)]
#[non_exhaustive]
pub struct VersionstampSequence {
next_state: Option<Versionstamp>,
}
Expand Down