fix: sanitize NNBF characters in uploaded files #26022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
No changes detected in Branching Preview Branches by Supabase. |
jordienr
approved these changes
May 11, 2024
charislam
force-pushed
the
fix/storage-upload-mac-screenshots
branch
from
0397567
to
5036f2e
Compare
Storage maintains a list of allowed characters, which excludes some characters used automatically by OSes for naming files (e.g., Mac default screenshot naming). To preempt errors, replace any characters that aren't alphanumerics, underscores, hyphens, or periods with underscores. See: https://forum.obsidian.md/t/unable-to-attach-screenshot-images-in-macos-14-0-when-wikilinks-turned-off-urlencode-u-202f-char/68410/6
charislam
force-pushed
the
fix/storage-upload-mac-screenshots
branch
from
5036f2e
to
08119f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS 14.0+ uses a narrow no-break space (U+202F) in the timestamp of automatically named screenshots (12-hour clock only). This is not a valid filename character for storage, and screenshots are probably a common-ish use case, so treat this as a special case and replace with a normal space.
See:
To test: