Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add native sign in for Kakao with OIDC #25981

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nectarine
Copy link

@nectarine nectarine commented May 10, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

feature, docs update

What is the current behavior?

https://github.com/orgs/supabase/discussions/23368
Kakao provides two different keys which are REST API key, and Native app key.
Supabase accept only one key(currently REST API key), so it should accept both keys to provide seamless sign in process in native apps.

What is the new behavior?

스크린샷 2024-05-10 오후 2 37 33

A local dev studio doesn't show me a Provider section in Authentication > Configuration, but I added a new field for the Native app key, similar to Authorized Client IDs of Google

Also, I add the docs with native app sign in with trying my best to preserve original author's tone.

Additional context

supabase.auth also must be fixed to accept this new value EXTERNAL_KAKAO_NATIVE_APP_KEY.
(https://github.com/supabase/auth/blob/ed2b4907244281e4c54aaef74b1f4c8a8e3d97c9/internal/api/token_oidc.go#L77)
I'll make a new PR in that repository after this PR is accepted.

@nectarine nectarine requested a review from a team as a code owner May 10, 2024 05:42
Copy link

vercel bot commented May 10, 2024

@nectarine is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant