New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(docs): reorg google auth guide (web) #25969
Conversation
charislam
commented
May 9, 2024
- rearrange the page
- revalidate and revise the web instructions
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
No changes detected in Branching Preview Branches by Supabase. |
|
||
You can get both versions by using the in-built `crypto` library: | ||
|
||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrote this to work browser-side since that seems to fit more with the example (script tags, functions in browser global scope). Would appreciate a second set of 👀 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I would class it as "browser side" since it's actually the olden days server side. But sure we can try it. I don't think I've seen anyone in Supabase use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -1,26 +1,19 @@ | |||
--- | |||
id: 'auth-google' | |||
title: 'Login with Google' | |||
description: 'Use Sign in with Google on the web, in native apps or with Chrome extensions' | |||
description: 'Use Sign In with Google on the web, in native apps or with Chrome extensions' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the new styling we apply? Maybe we should leave it for another PR where all Sign in
is renamed to Sign In
?
Your call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll revert this 👍🏼
|
||
You can get both versions by using the in-built `crypto` library: | ||
|
||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I would class it as "browser side" since it's actually the olden days server side. But sure we can try it. I don't think I've seen anyone in Supabase use it.