Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(docs): reorg google auth guide (web) #25969

Merged
merged 3 commits into from May 22, 2024
Merged

Conversation

charislam
Copy link
Contributor

  • rearrange the page
  • revalidate and revise the web instructions

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ❌ Failed (Inspect) May 22, 2024 6:38pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:38pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:38pm
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:38pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) May 22, 2024 6:38pm
studio ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 6:38pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 6:38pm

Copy link

supabase bot commented May 9, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.


You can get both versions by using the in-built `crypto` library:

```js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrote this to work browser-side since that seems to fit more with the example (script tags, functions in browser global scope). Would appreciate a second set of 👀 !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I would class it as "browser side" since it's actually the olden days server side. But sure we can try it. I don't think I've seen anyone in Supabase use it.

Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -1,26 +1,19 @@
---
id: 'auth-google'
title: 'Login with Google'
description: 'Use Sign in with Google on the web, in native apps or with Chrome extensions'
description: 'Use Sign In with Google on the web, in native apps or with Chrome extensions'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the new styling we apply? Maybe we should leave it for another PR where all Sign in is renamed to Sign In?

Your call!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll revert this 👍🏼


You can get both versions by using the in-built `crypto` library:

```js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I would class it as "browser side" since it's actually the olden days server side. But sure we can try it. I don't think I've seen anyone in Supabase use it.

@charislam charislam enabled auto-merge (squash) May 22, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants