Chore/show unlock icon next to view entities #23238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes detected in Branching Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
saltcod
commented
May 6, 2024
| </Popover_Shadcn_> | ||
| )} | ||
|
|
||
| {isForeignTable && entityType.schema === 'public' && ( |
There was a problem hiding this comment.
these are a little repetitive, but i converted them to a component and seemed to make it slightly worse.
ex: these have a link as the CTA, the tables CTA has an onClick handler.
….com:supabase/supabase into chore/show-unlock-icon-next-to-view-entities
ivasilov
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
— want to show icons next to views / materialized views / foreign tables if they don't meet security conditions
— show warnings / more info in GridHeaderActions based on this info
To test:
https://www.notion.so/supabase/Show-warning-if-there-is-a-foreign-table-materialized-view-table-in-a-schema-exposed-to-postgrest-bfb729d8a6c049f9944cb0405ad68f6e