Update the after_filter for auto-commit to be overridable on a per class basis. #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have situations where a controller should avoid committing to Solr since the immediate availability of a document is not critical. The case we use this for is on API calls where we want to do the indexing inline (so we give some back-pressure on the caller) but the update doesn't need to be immediately available. These API calls happen frequently so reducing load on Solr is important.
This could be implemented with the
auto_commit_after_request: false
option, and then add the commit as anafter_filter
everywhere we want it, but this use case is a bit of an inversion of howauto_commit_after_request
is best used.