Add ability to specify multiple hosts in sunspot.yml as an array (fixes #608) #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2016
|
@heaven seem like this one got stuck? |
|
Hi, yes, the rsolr team didn't accept my patch, even though we use our fork for a few years already without any issues. I will check the upstream and try adding a better implementation for this, perhaps they will accept it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All merge conflicts were resolved. I did not update the readme yet, until the RSolr patch accepted (I will also create a new pull request for RSolr today and reference it here).
Added a new pull request to RSolr: rsolr/rsolr#138