Added support for a string literal arguments to functions, which are pas... #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and the example added (and the function I and the author of issue #592 wanted to work) is directly from http://wiki.apache.org/solr/SolrRelevancyFAQ#How_can_I_boost_the_score_of_newer_documents |
hybridindie
added a commit
to hybridindie/sunspot
that referenced
this pull request
Mar 1, 2015
|
I'll be able to merge this if you provide a test to verify the behaviour instead of just removing the test that expects it to explode. |
|
Okay, I added a simple test. Let me know if there's more you'd like done. |
|
Just rebased this to be based off the latest version. (And mistakes while doing so meant this was closed for a bit due to my branch being identical to the main branch.) |
added 2 commits
November 8, 2015 16:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...sed through to Solr.