Fix rails 7.1 deprecation warning #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything we can do to fast track this PR merge? Our logs are flooded with deprecation warnings since we upgraded to Rails 7.1. This is a trivial fix with no breaking changes. |
This PR addresses the following Rails 7.1 deprecation warnings.
```
DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`)
DEPRECATION WARNING: BOLD is deprecated! Use MODES[:bold] instead.
```
Below is the output from the original code and the code that replaces it.
Where the original code provided `BOLD` as the second argument it was
generating the bold terminal escape sequence, '\e[1m`, twice which was
not achieving anything in addition to turning on bold.
Original: color(event.payload[:path], BOLD, true) => "\e[1m\e[1mupdate\e[0m"
Suggested: color(event.payload[:path], nil, bold: true) => "\e[1mupdate\e[0m"
Original: color(name, GREEN, true) => "\e[1m\e[32mSOLR Request (21.4ms)\e[0m"
Suggested: color(name, GREEN, bold: true) => "\e[1m\e[32mSOLR Request (21.4ms)\e[0m"
mark-young-atg
force-pushed
the
fix_rails_71_deprecation_warning
branch
from
c019e9f
to
74168e6
Compare
|
I have just rebased this with master. No changes were required. The file affected by this change hasn't been touched for 11 years. Would it be possible to trigger the merge checks so we can see if the tests pass across all the platform configurations? |
|
+1 to this |
|
+1 |
1 similar comment
|
+1 |
|
+1 |
|
+1 |
1 similar comment
|
+1 |
7 tasks
|
ping |
|
Dear anyone in the org, plz help @alindeman, @ghempton , @nz, @outoftime , @runlevel5 , @rywall, @vanstee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following Rails 7.1 deprecation warnings.
Below is the output from the original code and the code that replaces it. Where the original code provided
BOLDas the second argument it was generating the bold terminal escape sequence ("\e[1m") twice which was not achieving anything in addition to turning on bold.