-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4 #5
base: master
Are you sure you want to change the base?
Release v4 #5
Conversation
Thanks. Tested eab3bf6 on Ubuntu 20.04. The toolbar is rendered, but the canvas is not. By the way, new flake8 output added by your commits;
|
@quozl I have made the suggested changes |
The activity does not stop running. Confirmed by executing it from terminal with sugar-activity3 To reproduce - Choose a game of 2 or 3 or 4 players from crazyeights box. Now click the stop button. The activity doen't stop execution.
The toolbar is rendered, but the canvas is not. ^C gave me a traceback in pygame.camera.init; SystemError: bad call flags. This is on a VM under QEMU/KVM. The code has both a call to pygame.camera.init in run.py, and mentions pygame.camera in activity.py. I'm not sure why. |
Thanks. Also affects Pointillism activity. Ubuntu 20.04, Python 3.8.2, Pygame 1.9.6. We had this same problem once before in Pointillism, and we added an exception handler to ignore it. How do you propose to handle the problem? |
I looked at this commit in pointillism activity. I haven't tested that activity before, what does camera do in the activity. |
Tested. After finishing a game of two players, activity seems to refuse input, can't start a new game by clicking on number of players. This shows in the logs,
|
I will check this activity tomorrow, sorry for the delay |
@chimosky Thanks for noticing! Yes that does happen, looking up the code to find what might have caused this. |
|
Yes, I did look up the source code for this activity. However, I played the activity multiple times; I didnot encounter a situation where camera was used/ required. |
Can you reverse engineer the condition that leads to |
The activity does not stop running. Fixed in 9ebc08d
Release the activity
Tested; no errors for me.
@quozl @chimosky should I go ahead with release changes?