Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added an acronym for rank too long #43 #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added an acronym for rank too long #43 #55

wants to merge 1 commit into from

Conversation

akashrajxyz
Copy link

#43

sudiptob2
sudiptob2 reviewed Apr 7, 2023
View reviewed changes
Copy link
Owner

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test.

app/constant.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can keep the default length to 10. And please check for "grandmaster" rank it works or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudiptob2 sudiptob2 sudiptob2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akashrajxyz @sudiptob2