Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

fix($mochaTestFramework): Fix testFramework addTest hook #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix($mochaTestFramework): Fix testFramework addTest hook #8

wants to merge 1 commit into from

Conversation

jeznag
Copy link

@jeznag jeznag commented Mar 15, 2017

It was breaking for BDD tests

issue #7

It was breaking for BDD tests

issue-7
@simondel
Copy link
Member

Thanks for taking the time to make changes to the code! Could you add some tests so we know the bug won't come up again? Feel free to add actual test/source files to the test resources folder.

@nicojs
Copy link
Member

nicojs commented Mar 19, 2017

@jeznag wow you found my dirty hack :)

I understand that the code doesn't break anymore, but will the filtering work for BDD tests? I've got the feeling that tests aren't filtered and thus: every test runs for every mutant. In that case we should just remove this feature all together and throw an error instead.

Also see my update on stryker-mutator/stryker-mutator.github.io#29 for more info about the history of this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants