Instant Debits: wrote UI tests for Instant Debits #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaidis-stripe
force-pushed
the
kg-instadeb-tests
branch
from
92d9071
to
c6ef598
Compare
kgaidis-stripe
commented
May 16, 2024
| @@ -95,6 +95,8 @@ struct PaymentSheetTestPlayground: View { | |||
| SettingPickerView(setting: $playgroundController.settings.currency) | |||
| SettingPickerView(setting: merchantCountryBinding) | |||
| SettingView(setting: $playgroundController.settings.apmsEnabled) | |||
| TextField("Supported Payment Methods (comma separated)", text: supportedPaymentMethodsBinding) | |||
There was a problem hiding this comment.
This is a little funky, but copied from Android: stripe/stripe-android#8428
kgaidis-stripe
commented
May 16, 2024
Example/PaymentSheet Example/PaymentSheet Example/PlaygroundController.swift
Outdated
Show resolved
Hide resolved
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
kgaidis-stripe
added a commit
that referenced
this pull request
May 20, 2024
## Summary my [recently merged PR](#3528) intersected with another [recently merged PR](#3592) so right now there are build errors on `master` ## Testing Build now succeeds & make sure tests pass on the PR (this Instant Debits feature is actually unreleased and am still iterating on it as we speak so will be testing it a lot in [other PR's](#3585) too)
kgaidis-stripe
force-pushed
the
kg-instadeb-tests
branch
3 times, most recently
from
13b8db2
to
7af9e23
Compare
kgaidis-stripe
force-pushed
the
kg-instadeb-tests
branch
from
7af9e23
to
15929c6
Compare
kgaidis-stripe
commented
May 21, 2024
Example/PaymentSheet Example/PaymentSheetUITest/PaymentSheetUITest.swift
Outdated
Show resolved
Hide resolved
|
Updated the PR so UI tests work with iOS 17 too (not just IOS 16): |
|
| Name | Version | Download | Change | Install | Change | Approval |
|---|---|---|---|---|---|---|
| StripePaymentsSize com.stripe.StripePaymentsSize |
1.0 (1) | 1.1 MB | ⬆️ 359 B (0.03%) | 3.9 MB | ⬆️ 1.3 kB (0.03%) | N/A |
| StripeSize com.stripe.StripeSize |
1.0 (1) | 2.3 MB | ⬆️ 798 B (0.03%) | 7.6 MB | ⬆️ 1.7 kB (0.02%) | N/A |
| StripePaymentsUISize com.stripe.StripePaymentsUISize |
1.0 (1) | 1.8 MB | ⬆️ 241 B (0.01%) | 6.1 MB | ⬆️ 1.3 kB (0.02%) | N/A |
| StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize |
1.0 (1) | 1.2 MB | ⬆️ 28 B | 3.9 MB | ⬆️ 116 B | N/A |
| StripeApplePaySize com.stripe.StripeApplePaySize |
1.0 (1) | 422.6 kB | ⬆️ 232 B (0.05%) | 1.5 MB | ⬆️ 116 B | N/A |
| StripePaymentSheetSize com.stripe.StripePaymentSheetSize |
1.0 (1) | 3.2 MB | ⬆️ 7.5 kB (0.23%) | 9.7 MB | ⬆️ 35.9 kB (0.37%) | N/A |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 1.3 kB (0.03%)
Total download size change: ⬆️ 359 B (0.03%)
Largest size changes
| Item | Install Size Change |
|---|---|
| StripePayments.STPPaymentHandler._handleNextAction(forPayment,wit... | ⬆️ 852 B |
| StripePayments.STPPaymentHandler.handleNextAction(for,with,return... | ⬇️ -712 B |
| 📝 StripePayments.STPPaymentHandler.init(apiClient,threeDSCustomizat... | ⬆️ 504 B |
| Other | ⬆️ 658 B |
View Treemap
StripeSize 1.0 (1)
com.stripe.StripeSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 1.7 kB (0.02%)
Total download size change: ⬆️ 798 B (0.03%)
Largest size changes
| Item | Install Size Change |
|---|---|
| StripePayments.STPPaymentHandler._handleNextAction(forPayment,wit... | ⬆️ 852 B |
| StripePayments.STPPaymentHandler.handleNextAction(for,with,return... | ⬇️ -712 B |
| 📝 StripePayments.STPPaymentHandler.init(apiClient,threeDSCustomizat... | ⬆️ 504 B |
| Other | ⬆️ 1.1 kB |
View Treemap
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 1.3 kB (0.02%)
Total download size change: ⬆️ 241 B (0.01%)
Largest size changes
| Item | Install Size Change |
|---|---|
| StripePayments.STPPaymentHandler._handleNextAction(forPayment,wit... | ⬆️ 852 B |
| StripePayments.STPPaymentHandler.handleNextAction(for,with,return... | ⬇️ -712 B |
| 📝 StripePayments.STPPaymentHandler.init(apiClient,threeDSCustomizat... | ⬆️ 504 B |
| Other | ⬆️ 658 B |
View Treemap
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 116 B
Total download size change: ⬆️ 28 B
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 116 B |
View Treemap
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 116 B
Total download size change: ⬆️ 232 B (0.05%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 116 B |
View Treemap
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 35.9 kB (0.37%)
Total download size change: ⬆️ 7.5 kB (0.23%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 StripePaymentSheet.VerticalPaymentMethodListView.init(savedPaymen... | ⬇️ -4.7 kB |
| 📝 StripePaymentSheet.VerticalPaymentMethodListView.init(savedPaymen... | ⬆️ 4.6 kB |
| 🗑 StripePaymentSheet.VerticalPaymentMethodListSelection | ⬇️ -3.9 kB |
| 📝 StripePaymentSheet.VerticalSavedPaymentMethodsViewController.init... | ⬆️ 2.8 kB |
| 🗑 StripePaymentSheet.VerticalSavedPaymentMethodsViewController.init... | ⬇️ -2.6 kB |
View Treemap
🛸 Powered by Emerge Tools
bric-stripe
previously approved these changes
May 24, 2024
Example/PaymentSheet Example/PaymentSheet Example/PlaygroundController.swift
Outdated
Show resolved
Hide resolved
Example/PaymentSheet Example/PaymentSheetUITest/PaymentSheetUITest.swift
Outdated
Show resolved
Hide resolved
|
OK I made changes based on your feedback: (...but it will require another approval as it dismissed the approve) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tests for Instant Debits in Payment Sheet.
This was the PR that introduced Instant Debits:
This PR also introduces a new field in the Payment Sheet app ("supported payment methods"). It's a little funky, but I copied what Android did:
Testing
Tests passed in PR/bitrise (https://app.bitrise.io/build/18ab4632-a2fb-4740-905e-43b319c79fd7):
Tests passed in Xcode:
This is the new field: