Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Link button metrics #3561

Merged
merged 3 commits into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ final class PayWithLinkButton: UIControl {

struct Constants {
static let defaultSize: CGSize = .init(width: 200, height: 44)
static let logoSize: CGSize = .init(width: 29, height: 13)
static let logoSize: CGSize = .init(width: 48, height: 16)
static let cardBrandSize: CGSize = .init(width: 28, height: 18)
static let arrowSize: CGSize = .init(width: 17, height: 13)
static let separatorSize: CGSize = .init(width: 1, height: 22)
Expand Down Expand Up @@ -104,7 +104,7 @@ final class PayWithLinkButton: UIControl {
linkView.adjustsFontForContentSizeCategory = true
linkView.translatesAutoresizingMaskIntoConstraints = false
linkView.font = UIFont.systemFont(ofSize: 20, weight: .medium)
.scaled(withTextStyle: .callout, maximumPointSize: 22)
.scaled(withTextStyle: .callout, maximumPointSize: 21)

let payWithLinkString = NSMutableAttributedString(string: String.Localized.pay_with_link)

Expand Down Expand Up @@ -154,8 +154,8 @@ final class PayWithLinkButton: UIControl {
emailSeparatorView,
emailLabel,
].compactMap({ $0 }))
stackView.spacing = 8
stackView.setCustomSpacing(14, after: logoView)
stackView.spacing = 10
stackView.setCustomSpacing(12, after: logoView)
stackView.translatesAutoresizingMaskIntoConstraints = false
stackView.distribution = .fill
stackView.alignment = .center
Expand Down
Binary file modified ...Tests.PaymentSheetSnapshotTests/[email protected]
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...tTests.PaymentSheetSnapshotTests/[email protected]
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...Tests.PayWithLinkButtonSnapshotTests/[email protected]
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.