Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the scanned name and expiry date of a card publicly visible #3539

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

sgrant-stripe
Copy link
Contributor

Summary

Remove @_spi for ScannedCard properties.
Fixes #2484 and #2875

Motivation

In order to autofill our card entry form we need the scanned details, but for some reason they're blocked from being publicly visible.

Testing

N/A

Changelog

[Changed] ScannedCard to allow access for expiryMonth, expiryYear and name.

Copy link

github-actions bot commented Apr 25, 2024

⚠️ Public API changes detected:

StripeCardScan

+ public let expiryMonth: Swift.String?
+ public let expiryYear: Swift.String?
+ public let name: Swift.String?

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Credit card scanner should scan expiration date and not only "pan"
2 participants