Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for on_behalf_of to STPPaymentCardTextField and STPCardFormView #3529

Merged
merged 4 commits into from May 17, 2024

Conversation

davidme-stripe
Copy link
Contributor

@davidme-stripe davidme-stripe commented Apr 19, 2024

Summary

Add support for on_behalf_of to STPPaymentCardTextField and STPCardFormView, and pass it to the Card Element endpoint.

Motivation

Enabling CBC for Connect users of the Card Element.

Testing

Added tests.

Changelog

Added.

Copy link

github-actions bot commented Apr 19, 2024

⚠️ Public API changes detected:

StripePaymentsUI

+ @_Concurrency.MainActor(unsafe) public var onBehalfOf: Swift.String? {
+ get
+ set
+ }
+ @_Concurrency.MainActor(unsafe) public var onBehalfOf: Swift.String? {
+ get
+ set
+ }

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

@davidme-stripe davidme-stripe marked this pull request as ready for review May 13, 2024 19:14
@davidme-stripe davidme-stripe requested review from a team as code owners May 13, 2024 19:14
@davidme-stripe davidme-stripe requested review from a team and yuki-stripe and removed request for a team May 13, 2024 19:14
@davidme-stripe davidme-stripe merged commit f72078f into master May 17, 2024
4 checks passed
@davidme-stripe davidme-stripe deleted the davidme/cbc-obo branch May 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants