Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach duplicated payment methods from PS & FlowController #2935

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

wooj-stripe
Copy link
Collaborator

Summary

Web is deleting similar payment methods client side in this manner, so we will follow suit until a better solution arises.

Motivation

Part of project to de-dupe saved payment methods

Testing

Will add UI tests

Base automatically changed from wooj/SPMes to master October 18, 2023 17:35
@emerge-tools
Copy link

emerge-tools bot commented Oct 18, 2023

3 builds increased size, 4 builds decreased size

Name Version Download Change Install Change
StripePaymentSheetSize 1.0 (1) 3.2 MB ⬇️ 200.6 kB (-5.82%) 9.0 MB ⬆️ 156.4 kB (1.77%)
⚠️ StripeSize 1.0 (1) 2.6 MB ⬇️ 92.5 kB (-3.43%) 7.6 MB ⬆️ 150.7 kB (2.04%)
StripePaymentsUISize 1.0 (1) 2.1 MB ⬇️ 78.5 kB (-3.68%) 6.0 MB ⬆️ 80.3 kB (1.37%)
StripePaymentsSize 1.0 (1) 1.2 MB ⬇️ 27.2 kB (-2.15%) 3.7 MB ⬇️ 53.1 kB (-1.42%)
StripeIdentitySize 1.0 (1) 1.4 MB ⬇️ 40.7 kB (-2.77%) 3.9 MB ⬇️ 31.6 kB (-0.81%)
StripeFinancialConnectionsSize 1.0 (1) 1.5 MB ⬇️ 27.2 kB (-1.75%) 4.0 MB ⬇️ 27.6 kB (-0.68%)
StripeApplePaySize 1.0 (1) 498.9 kB ⬇️ 173 B (-0.03%) 1.5 MB ⬇️ 500 B (-0.03%)

StripePaymentSheetSize 1.0 (1)

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 156.4 kB (1.77%)
Total download size change: ⬇️ 200.6 kB (-5.82%)

Largest size changes

Item Install Size Change
🗑 Assets.car ⬇️ -192.5 kB
🗑 Assets.car ⬇️ -159.7 kB
🗑 Assets.car ⬇️ -69.6 kB
🗑 Assets.car ⬇️ -24.6 kB
🗑 StripePaymentSheet.PaymentSheet.confirmAfterHandlingLocalActions(... ⬇️ -20.4 kB

Image of diff

StripeSize 1.0 (1)

⚖️ Compare build
⏱️ Analyze build performance

⚠️ Install size change increased by >= 2%
Total install size change: ⬆️ 150.7 kB (2.04%)
Total download size change: ⬇️ 92.5 kB (-3.43%)

Largest size changes

Item Install Size Change
🗑 Assets.car ⬇️ -159.7 kB
🗑 Assets.car ⬇️ -122.9 kB
🗑 Assets.car ⬇️ -69.6 kB
🗑 Assets.car ⬇️ -24.6 kB
📝 [email protected] ⬆️ 16.4 kB

Image of diff

StripePaymentsUISize 1.0 (1)

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 80.3 kB (1.37%)
Total download size change: ⬇️ 78.5 kB (-3.68%)

Largest size changes

Item Install Size Change
🗑 Assets.car ⬇️ -159.7 kB
🗑 Assets.car ⬇️ -69.6 kB
🗑 Assets.car ⬇️ -24.6 kB
📝 cartes-bancaires-logo.png ⬆️ 16.4 kB
📝 [email protected] ⬆️ 12.3 kB

Image of diff

StripePaymentsSize 1.0 (1)

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 53.1 kB (-1.42%)
Total download size change: ⬇️ 27.2 kB (-2.15%)

Largest size changes

Item Install Size Change
🗑 Assets.car ⬇️ -69.6 kB
📝 cartes-bancaires-logo.png ⬆️ 16.4 kB
📝 [email protected] ⬆️ 8.2 kB
DYLD.Exports ⬇️ -7.2 kB
🗑 StripePayments.STPPaymentHandler._handleRedirect(to,fallbackURL,r... ⬇️ -6.1 kB

Image of diff

StripeIdentitySize 1.0 (1)

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 31.6 kB (-0.81%)
Total download size change: ⬇️ 40.7 kB (-2.77%)

Largest size changes

Item Install Size Change
🗑 Assets.car ⬇️ -24.6 kB
📝 [email protected] ⬆️ 4.1 kB
📝 [email protected] ⬆️ 4.1 kB
📝 [email protected] ⬆️ 4.1 kB
📝 [email protected] ⬆️ 4.1 kB

Image of diff

StripeFinancialConnectionsSize 1.0 (1)

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 27.6 kB (-0.68%)
Total download size change: ⬇️ 27.2 kB (-1.75%)

Largest size changes

Item Install Size Change
🗑 Assets.car ⬇️ -24.6 kB
📝 StripeFinancialConnections.NativeFlowController.closeAuthFlow(sho... ⬆️ 4.3 kB
📝 [email protected] ⬆️ 4.1 kB
📝 [email protected] ⬆️ 4.1 kB
📝 [email protected] ⬆️ 4.1 kB

Image of diff

StripeApplePaySize 1.0 (1)

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 500 B (-0.03%)
Total download size change: ⬇️ 173 B (-0.03%)

Largest size changes

Item Install Size Change
Other ⬇️ -500 B

Image of diff


🛸 Powered by Emerge Tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant