Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the new skip account selection field #2233

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Respect the new skip account selection field #2233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...eFinancialConnections/Source/API Bindings/Models/FinancialConnectionsPartnerAccount.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ struct FinancialConnectionsDisabledPartnerAccount {
struct FinancialConnectionsAuthSessionAccounts: Decodable {
let data: [FinancialConnectionsPartnerAccount]
let nextPane: FinancialConnectionsSessionManifest.NextPane
let skipAccountSelection: Bool?
}
4 changes: 2 additions & 2 deletions .../StripeFinancialConnections/Source/Native/AccountPicker/AccountPickerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ final class AccountPickerViewController: UIViewController {
switch result {
case .success(let accountsPayload):
let accounts = accountsPayload.data

let shouldSkipAccountSelection = accountsPayload.skipAccountSelection ?? self.dataSource.authSession.skipAccountSelection ?? false
if !accounts.isEmpty {
self.dataSource
.analyticsClient
Expand All @@ -154,7 +154,7 @@ final class AccountPickerViewController: UIViewController {
debugDescription: "API returned an empty list of accounts"
)
)
} else if self.dataSource.authSession.skipAccountSelection ?? false {
} else if shouldSkipAccountSelection {
self.delegate?.accountPickerViewController(
self,
didSelectAccounts: accounts
Expand Down