Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional func didSelectPaymentMethod to STPApplePayContextDelegate #1865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wootage
Copy link

@wootage wootage commented Aug 25, 2021

Summary

Implemented paymentAuthorizationController(_:didSelectPaymentMethod:handler:) from the PKPaymentAuthorizationControllerDelegate
Added applePayContext(_:didSelectPaymentMethod:handler: to STPApplePayContextDelegate and invoke it when paymentAuthorizationController(_:didSelectPaymentMethod:handler:) is called

Motivation

We have a case where we don't gather the shipping address and are relying sorely on the billing one to calculate the taxes

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2021

CLA assistant check
All committers have signed the CLA.

@davidme-stripe
Copy link
Contributor

Thanks for your submission! (And sorry for the delay in responding!) We'll need to discuss this internally a bit, but I think this is a good API change. We'll keep this open to track adding this feature.

@davidme-stripe davidme-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants