Instant Debits: cleaned up logic.

stripe · May 8, 2024 · 6529b1c · 6529b1c
1 parent ebf04fa
commit 6529b1c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 20 deletions.
diff --git a/Stripe.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Stripe.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -1,4 +1,5 @@
 {
+ "originHash" : "a6099f8b6f6e3d4e6a249794b40206685b3930858d8b410d4e86ef38217df380",
  "pins" : [
  {
  "identity" : "capture-core-sp",

diff --git a/StripeFinancialConnections/StripeFinancialConnections/Source/FinancialConnectionsSheet.swift b/StripeFinancialConnections/StripeFinancialConnections/Source/FinancialConnectionsSheet.swift
@@ -248,7 +248,8 @@ final public class FinancialConnectionsSheet {
 /// :nodoc:
 extension FinancialConnectionsSheet: HostControllerDelegate {
  func hostController(
- _ hostController: HostController, viewController: UIViewController,
+ _ hostController: HostController,
+ viewController: UIViewController,
  didFinish result: HostControllerResult
  ) {
  viewController.dismiss(

diff --git a/...ipePaymentSheet/Source/PaymentSheet/PaymentSheetFormFactory/PaymentSheetFormFactory.swift b/...ipePaymentSheet/Source/PaymentSheet/PaymentSheetFormFactory/PaymentSheetFormFactory.swift
@@ -716,12 +716,7 @@ extension PaymentSheetFormFactory {
  )
  }
  }(),
- emailElement: (
- // TODO: does this email logic make sense?
- (configuration.billingDetailsCollectionConfiguration.email != .never)
- ? makeEmail()
- : nil
- ),
+ emailElement: makeEmail(),
  theme: theme
  )
  }

diff --git a/...ipePaymentSheet/Source/PaymentSheet/USBankAccount/InstantDebitsPaymentMethodElement.swift b/...ipePaymentSheet/Source/PaymentSheet/USBankAccount/InstantDebitsPaymentMethodElement.swift
@@ -93,19 +93,6 @@ final class InstantDebitsPaymentMethodElement: Element {
  emailElement: PaymentMethodElement?,
  theme: ElementsUITheme = .default
  ) {
- let willShowEmailField = (configuration.billingDetailsCollectionConfiguration.email != .never)
- let hasDefaultEmail = (
- configuration.billingDetailsCollectionConfiguration.attachDefaultsToPaymentMethod
- && configuration.defaultBillingDetails.email != nil
- )
-
- // Fail loudly: This is an integration error
- assert(
- // TODO: is it a mandatory step to provide an email???
- (willShowEmailField || hasDefaultEmail),
- "If email is not collected, they must be provided through defaults"
- )
-
  self.configuration = configuration
  self.linkedBankInfoView = BankAccountInfoView(frame: .zero, theme: theme)
  self.linkedBankInfoSectionElement = SectionElement(