Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github] add pagerduty alert step to package manager test #1177

Merged
merged 4 commits into from May 15, 2024

Conversation

charliecruzan-stripe
Copy link
Contributor

@charliecruzan-stripe charliecruzan-stripe commented May 2, 2024

Reviewers

cc @stripe/developer-products

Summary

Adds a job that runs after all other jobs are completed- if any of those jobs failed, this job will run (which will page during business hours only).

You can see how this works via the test runs on the commits below. In first commit, the action does NOT run the pagerduty step since all needed jobs pass: https://github.com/stripe/stripe-cli/actions/runs/8929598608

In the second commit, the action does run since i forced the homebrew job fail: https://github.com/stripe/stripe-cli/actions/runs/8929626125

I've already added the secret to https://github.com/stripe/stripe-cli/settings/secrets/actions

@charliecruzan-stripe charliecruzan-stripe requested a review from a team as a code owner May 2, 2024 19:48
@charliecruzan-stripe
Copy link
Contributor Author

r? @fhats-stripe

@charliecruzan-stripe charliecruzan-stripe merged commit e719e72 into master May 15, 2024
7 checks passed
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-add-paging branch May 15, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants