Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the rest of errors over to StateFlow. #8411

Merged
merged 3 commits into from May 6, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented May 2, 2024

Summary

Moving the rest of errors to be stateflows.

Copy link
Contributor

github-actions bot commented May 2, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │ +184 B │   8.6 MiB │   8.6 MiB │ +1.1 KiB 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  25.2 KiB │  25.2 KiB │      0 B 
      res │ 907.5 KiB │ 907.5 KiB │    0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │    0 B │   2.9 MiB │   2.9 MiB │      0 B 
    other │   194 KiB │   194 KiB │   +5 B │ 423.6 KiB │ 423.6 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  12.7 MiB │  12.7 MiB │ +189 B │  21.6 MiB │  21.6 MiB │ +1.1 KiB 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 43006 │ 43007 │ +1 (+2 -1)   
   types │ 14756 │ 14756 │  0 (+0 -0)   
 classes │ 12461 │ 12461 │  0 (+0 -0)   
 methods │ 61021 │ 61021 │  0 (+31 -31) 
  fields │ 40302 │ 40303 │ +1 (+27 -26) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6028 │ 6028 │  0
APK
    compressed     │     uncompressed     │                                           
──────────┬────────┼───────────┬──────────┤                                           
 size     │ diff   │ size      │ diff     │ path                                      
──────────┼────────┼───────────┼──────────┼───────────────────────────────────────────
  3.9 MiB │ +184 B │   8.6 MiB │ +1.1 KiB │ ∆ classes.dex                             
 52.7 KiB │   +8 B │ 116.7 KiB │      0 B │ ∆ META-INF/CERT.SF                        
 49.4 KiB │   -5 B │ 116.6 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
    271 B │   +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │   +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
──────────┼────────┼───────────┼──────────┼───────────────────────────────────────────
    4 MiB │ +189 B │   8.8 MiB │ +1.1 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   43006 │ 43007 │ +1 (+2 -1) 
  
  + sectionFieldElements
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:4952457,r8-mode:full,version:8.3.37}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:fe99b14,r8-mode:full,version:8.3.37}
  

METHODS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   61021 │ 61021 │ 0 (+31 -31) 
  
  + G6.k a(boolean, b, Set, O, k, int)
  + I6.M b(a, String, String, boolean, boolean, boolean, boolean, e1, e1, g0, b, O, I0, G1, a, k, int, int)
  + I6.M c(boolean, b, O, I0, k, int)
  + I6.M e(int, k, a, b, O, g0, I0, e1, e1, boolean, boolean, boolean)
  + I6.M f(int, k, a, b, O, g0, I0, e1, e1, boolean, boolean, boolean)
  + X7.F1 h() → m0
  + X7.W h() → m0
  + X7.a0 h() → m0
  + X7.o0 h() → m0
  + X7.v0 h() → m0
  + e8.C h() → m0
  + e8.F0 h() → m0
  + e8.H0 h() → m0
  + e8.Q0 h() → m0
  + e8.Y0 h() → m0
  + e8.a <clinit>()
  + e8.a <init>(int)
  + e8.a K(Object) → Object
  + e8.a a(c) → String
  + e8.a b(List) → b
  + e8.a c(w)
  + e8.b <init>(b)
  + e8.b e(boolean, O0, q, Set, O, int, int, k, int)
  + e8.b h() → m0
  + e8.g0 h() → m0
  + e8.g h() → m0
  + e8.s h() → m0
  + e8.x <init>(Set, boolean, a, a, int)
  + h7.l <init>(a, String, String, boolean, boolean, boolean, boolean, e1, e1, g0, b, O, I0, G1, a, int, int)
  + h7.m <init>(a, boolean, boolean, boolean, e1, e1, g0, b, O, I0, int)
  + h7.m <init>(boolean, a, boolean, boolean, e1, e1, g0, b, O, I0, int)
  
  - G6.k a(boolean, a, Set, O, k, int)
  - I6.M b(a, String, String, boolean, boolean, boolean, boolean, e1, e1, g0, a, O, I0, G1, a, k, int, int)
  - I6.M c(boolean, a, O, I0, k, int)
  - I6.M e(int, k, a, a, O, g0, I0, e1, e1, boolean, boolean, boolean)
  - I6.M f(int, k, a, a, O, g0, I0, e1, e1, boolean, boolean, boolean)
  - X7.F1 h() → f
  - X7.W h() → f
  - X7.a0 h() → f
  - X7.o0 h() → f
  - X7.v0 h() → f
  - e8.C h() → f
  - e8.F0 h() → f
  - e8.H0 h() → f
  - e8.Q0 h() → f
  - e8.Y0 h() → f
  - e8.a <init>(b)
  - e8.a e(boolean, O0, q, Set, O, int, int, k, int)
  - e8.a h() → f
  - e8.b <clinit>()
  - e8.b <init>(int)
  - e8.b K(Object) → Object
  - e8.b a(c) → String
  - e8.b b(List) → b
  - e8.b c(w)
  - e8.g0 h() → f
  - e8.g h() → f
  - e8.s h() → f
  - e8.x <init>(Set, boolean, b, b, int)
  - h7.l <init>(a, String, String, boolean, boolean, boolean, boolean, e1, e1, g0, a, O, I0, G1, a, int, int)
  - h7.m <init>(a, boolean, boolean, boolean, e1, e1, g0, a, O, I0, int)
  - h7.m <init>(boolean, a, boolean, boolean, e1, e1, g0, a, O, I0, int)
  

FIELDS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   40302 │ 40303 │ +1 (+27 -26) 
  
  + X7.W g: b
  + X7.a0 d: b
  + e8.F0 b: b
  + e8.J0 b: b
  + e8.a S: int
  + e8.a T: a
  + e8.a U: a
  + e8.a V: a
  + e8.a W: a
  + e8.a X: a
  + e8.a Y: a
  + e8.a Z: a
  + e8.a a0: a
  + e8.a b0: a
  + e8.a c0: a
  + e8.a d0: a
  + e8.a e0: a
  + e8.a f0: a
  + e8.a g0: a
  + e8.a h0: a
  + e8.a i0: a
  + e8.a j0: a
  + e8.a k0: a
  + e8.b a: m0
  + e8.b b: b
  + e8.c n: b
  + h7.l c0: b
  
  - X7.W g: f
  - X7.a0 d: f
  - e8.F0 b: M
  - e8.J0 b: M
  - e8.a a: m0
  - e8.a b: n
  - e8.b S: int
  - e8.b T: b
  - e8.b U: b
  - e8.b V: b
  - e8.b W: b
  - e8.b X: b
  - e8.b Y: b
  - e8.b Z: b
  - e8.b a0: b
  - e8.b b0: b
  - e8.b c0: b
  - e8.b d0: b
  - e8.b e0: b
  - e8.b f0: b
  - e8.b g0: b
  - e8.b h0: b
  - e8.b i0: b
  - e8.b j0: b
  - e8.c n: a
  - h7.l c0: a

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/more-error-state-flow branch 2 times, most recently from 99ffc5c to 0180c95 Compare May 3, 2024 18:54
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/more-error-state-flow branch from 85bc434 to 1eccd99 Compare May 6, 2024 13:55
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review May 6, 2024 14:08
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners May 6, 2024 14:08
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) May 6, 2024 14:08
@jaynewstrom-stripe jaynewstrom-stripe merged commit 2f537f2 into master May 6, 2024
15 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/more-error-state-flow branch May 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants