Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrimaryButtonUiStateMapper to return state flow. #8394

Merged
merged 2 commits into from May 6, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented May 2, 2024

Summary

Continuing to move away from stateIn if we can avoid it. This is for PrimaryButtonUiStateMapper. We can't actually do the combineAsStateFlow in PrimaryButtonUiStateMapper, but this will get us ready to do it.

Copy link
Contributor

github-actions bot commented May 2, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ -9 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ -9 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21684 │ 21684 │ 0 (+0 -0) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31446 │ 31446 │ 0 (+0 -0) 
  fields │ 18315 │ 18315 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.1 KiB │ -4 B │   64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.9 KiB │ -4 B │ 63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 55.2 KiB │ -9 B │  128 KiB │  0 B │ (total)

)

val result = mapper.forCompleteFlow()

result.test {
assertThat(awaitItem()).isEqualTo(usBankButton)
awaitComplete()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state flows can never complete, so this assert wouldn't pass.

We don't actually rely on this behavior, or use it in our production codepaths, so it's safe to remove.

test also ensure we consumed all the events, so we're safe there.

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review May 2, 2024 14:27
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners May 2, 2024 14:27
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) May 2, 2024 14:28
samer-stripe
samer-stripe previously approved these changes May 2, 2024
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as draft May 2, 2024 16:58
auto-merge was automatically disabled May 2, 2024 16:58

Pull request was converted to draft

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/wallet-state-flow branch 3 times, most recently from ec2cf40 to c31645a Compare May 3, 2024 18:53
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review May 3, 2024 19:59
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) May 3, 2024 20:01
@jaynewstrom-stripe jaynewstrom-stripe merged commit 80859c9 into master May 6, 2024
12 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/wallet-state-flow branch May 6, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants