New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate SectionFieldErrorController
to StateFlow
#8351
Open
samer-stripe
wants to merge
2
commits into
master
Choose a base branch
from
samer/migrate-section-error-controller
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaynewstrom-stripe
previously approved these changes
Apr 25, 2024
samer-stripe
changed the title
Migrate
Migrate Apr 25, 2024
SectionFieldController
to StateFlow
SectionFieldErrorController
to StateFlow
Diffuse output:
APK
DEX
|
samer-stripe
force-pushed
the
samer/migrate-section-error-controller
branch
from
April 25, 2024 19:18
d95d0b0
to
f066394
Compare
jaynewstrom-stripe
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
SectionFieldErrorController
toStateFlow
Motivation
Helps move effort to migrate our
Flow
UI fields toStateFlow
Testing