Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SectionFieldErrorController to StateFlow #8351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Apr 25, 2024

Summary

Migrate SectionFieldErrorController to StateFlow

Motivation

Helps move effort to migrate our Flow UI fields to StateFlow

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe samer-stripe changed the title Migrate SectionFieldController to StateFlow Migrate SectionFieldErrorController to StateFlow Apr 25, 2024
@samer-stripe samer-stripe enabled auto-merge (squash) April 25, 2024 15:59
Copy link
Contributor

github-actions bot commented Apr 25, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.9 MiB │   3.9 MiB │ -506 B │   8.6 MiB │   8.6 MiB │ -972 B 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │    0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  24.9 KiB │  24.9 KiB │    0 B 
      res │ 907.5 KiB │ 907.5 KiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │   2.9 MiB │   2.9 MiB │   -9 B │   2.9 MiB │   2.9 MiB │   -9 B 
    other │   194 KiB │   194 KiB │   +3 B │ 423.6 KiB │ 423.6 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.7 MiB │  12.7 MiB │ -512 B │  21.6 MiB │  21.6 MiB │ -981 B 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 43050 │ 43047 │  -3 (+33 -36)     
   types │ 14776 │ 14772 │  -4 (+31 -35)     
 classes │ 12482 │ 12478 │  -4 (+1 -5)       
 methods │ 61043 │ 61033 │ -10 (+1201 -1211) 
  fields │ 40345 │ 40334 │ -11 (+843 -854)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6028 │ 6028 │  0
APK
    compressed     │    uncompressed    │                                
──────────┬────────┼───────────┬────────┤                                
 size     │ diff   │ size      │ diff   │ path                           
──────────┼────────┼───────────┼────────┼────────────────────────────────
  3.9 MiB │ -506 B │   8.6 MiB │ -972 B │ ∆ classes.dex                  
  7.4 KiB │   -7 B │   7.2 KiB │   -7 B │ ∆ assets/dexopt/baseline.prof  
 52.7 KiB │   +6 B │ 116.7 KiB │    0 B │ ∆ META-INF/CERT.SF             
 49.4 KiB │   -3 B │ 116.6 KiB │    0 B │ ∆ META-INF/MANIFEST.MF         
    872 B │   -2 B │     740 B │   -2 B │ ∆ assets/dexopt/baseline.profm 
──────────┼────────┼───────────┼────────┼────────────────────────────────
    4 MiB │ -512 B │   8.8 MiB │ -981 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   43050 │ 43047 │ -3 (+33 -36) 
  
  + LT8/l;
  + [LV7/B0;
  + [LV7/D1;
  + [LV7/E0;
  + [LV7/I0;
  + [LV7/J1;
  + [LV7/L0;
  + [LV7/M1;
  + [LV7/O0;
  + [LV7/P1;
  + [LV7/S0;
  + [LV7/W1;
  + [LV7/a1;
  + [LV7/a2;
  + [LV7/d1;
  + [LV7/d2;
  + [LV7/g1;
  + [LV7/j1;
  + [LV7/q1;
  + [LV7/t1;
  + [LV7/v1;
  + [LV7/y0;
  + [LV7/y1;
  + [Lc8/K;
  + [Lc8/O0;
  + [Lc8/O;
  + [Lc8/S0;
  + [Lc8/b0;
  + [Lc8/c0;
  + [Lc8/i;
  + [Lc8/x0;
  + sectionFieldElements
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:d076f89,r8-mode:full,version:8.3.37}
  
  - LU8/c;
  - LV7/g2;
  - Lc8/E1;
  - Lc8/F1;
  - Lc8/G1;
  - [LV7/C0;
  - [LV7/F0;
  - [LV7/F1;
  - [LV7/J0;
  - [LV7/K1;
  - [LV7/M0;
  - [LV7/N1;
  - [LV7/P0;
  - [LV7/Q1;
  - [LV7/T0;
  - [LV7/X1;
  - [LV7/b1;
  - [LV7/b2;
  - [LV7/e1;
  - [LV7/e2;
  - [LV7/h1;
  - [LV7/k1;
  - [LV7/r1;
  - [LV7/u1;
  - [LV7/w1;
  - [LV7/z0;
  - [LV7/z1;
  - [Lc8/M;
  - [Lc8/Q0;
  - [Lc8/Q;
  - [Lc8/W0;
  - [Lc8/d0;
  - [Lc8/e0;
  - [Lc8/l;
  - [Lc8/z0;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:c3e16f5,r8-mode:full,version:8.3.37}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   14776 │ 14772 │ -4 (+31 -35) 
  
  + LT8/l;
  + [LV7/B0;
  + [LV7/D1;
  + [LV7/E0;
  + [LV7/I0;
  + [LV7/J1;
  + [LV7/L0;
  + [LV7/M1;
  + [LV7/O0;
  + [LV7/P1;
  + [LV7/S0;
  + [LV7/W1;
  + [LV7/a1;
  + [LV7/a2;
  + [LV7/d1;
  + [LV7/d2;
  + [LV7/g1;
  + [LV7/j1;
  + [LV7/q1;
  + [LV7/t1;
  + [LV7/v1;
  + [LV7/y0;
  + [LV7/y1;
  + [Lc8/K;
  + [Lc8/O0;
  + [Lc8/O;
  + [Lc8/S0;
  + [Lc8/b0;
  + [Lc8/c0;
  + [Lc8/i;
  + [Lc8/x0;
  
  - LU8/c;
  - LV7/g2;
  - Lc8/E1;
  - Lc8/F1;
  - Lc8/G1;
  - [LV7/C0;
  - [LV7/F0;
  - [LV7/F1;
  - [LV7/J0;
  - [LV7/K1;
  - [LV7/M0;
  - [LV7/N1;
  - [LV7/P0;
  - [LV7/Q1;
  - [LV7/T0;
  - [LV7/X1;
  - [LV7/b1;
  - [LV7/b2;
  - [LV7/e1;
  - [LV7/e2;
  - [LV7/h1;
  - [LV7/k1;
  - [LV7/r1;
  - [LV7/u1;
  - [LV7/w1;
  - [LV7/z0;
  - [LV7/z1;
  - [Lc8/M;
  - [Lc8/Q0;
  - [Lc8/Q;
  - [Lc8/W0;
  - [Lc8/d0;
  - [Lc8/e0;
  - [Lc8/l;
  - [Lc8/z0;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   61043 │ 61033 │ -10 (+1201 -1211) 
  
  + A5.i <init>(boolean, String, String, V, String)
  + A7.b i(boolean, e1, a, int, m, boolean, e, k, int, int)
  + A7.b n(J0, e1, g0, e1, boolean, a, boolean, boolean, f, q, k, int, int)
  + C.i f0(D1, List, boolean, G0) → S0
  + C.i k(Integer, e1, g0, e1, a, boolean, boolean, boolean, f, boolean, a, q, m, m, m, k, int, int, int)
  + D.f U(j, P1, j) → ArrayList
  + D6.P <init>(C, int, k0)
  + D6.T <init>(Object, boolean, O0, q, Set, O, int, int, int, int)
  + D6.s1 e(boolean, I, O, k, int)
  + D6.s1 f(e1, boolean, O0, q, Set, O, int, int, k, int)
  + D6.s1 j(boolean, e1, boolean, boolean, k, int)
  + D6.s1 r(boolean, V, q, P, D, float, float, String, W, m, k, int, int)
  + D6.s1 v0(c, String, Q) → boolean
  + D6.s1 y(String, boolean, D, V, int, e, q, boolean, W, String, k, int)
  + E6.U <init>(k1, j)
  + E6.k A(boolean, O0, q, Set, O, int, int, k, int, int)
  + E6.k A0(c) → d1
  + E6.k B0(byte) → String
  + E6.k C0(f, f) → r
  + E6.k D0(int, b)
  + E6.k E0(long) → double
  + E6.k F0(c, f) → c
  + E6.k G0(c, J) → c
  + E6.k H0(j, e, e) → Object
  + E6.k I0(b, Object, b) → m
  + E6.k L(String, Enum[], String[], Annotation[][]) → w
  + E6.k M(b) → d
  + E6.k N(String, Enum[]) → w
  + E6.k O(f, long) → f
  + E6.k P(long, e) → Object
  + E6.k R(f) → f
  + E6.k S(f, int) → r
  + E6.k T(char, char, boolean) → boolean
  + E6.k U(Activity)
  + E6.k V(f) → x
  + E6.k W(f, e) → Object
  + E6.k X(f, e, e) → Object
  + E6.k Y(s0, l, e) → Object
  + E6.k Z(Object) → h
  + E6.k a(g, a, k, int, int)
  + E6.k a0(j) → H
  + E6.k b0(Context, int) → float
  + E6.k c0(b) → Class
  + E6.k e0(e) → j
  + E6.k f0(int, int, int) → int
  + E6.k g(boolean, a0, Set, O, k, int)
  + E6.k g0(Object) → s
  + E6.k h0(j, Throwable)
  + E6.k i0(View)
  + E6.k j0(c0, boolean, g0, int) → L
  + E6.k k0(Object) → boolean
  + E6.k l0(char) → boolean
  + E6.k m(Set, boolean, List, O, q, k, int, int)
  + E6.k m0(B, j, int, e, int) → s0
  + E6.k n0(String, Object) → P
  + E6.k o0(j, j) → j
  + E6.k p0(p, k) → q
  + E6.k q0(int, int, Object[])
  + E6.k r0(b, k) → String
  + E6.k s0(j, e) → Object
  + E6.k t0(e) → Object
  + E6.k u0(Te
...✂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants