Add ability to set on_behalf_of for CBC elements #8344

tjclawson-stripe · 2024-04-24T21:14:18Z

Summary

Adds ability for merchant to set onBehalfOf for CardInputWidget, CardFormView, and CardMultilineWidget

Motivation

MOBILESDK-1969
API REVIEW

Testing

Added tests
Modified tests
Manually verified

Changelog

See CHANGELOG.md

github-actions · 2024-04-24T21:20:26Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.9 MiB │   3.9 MiB │ +474 B │   8.6 MiB │   8.6 MiB │ +368 B 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │    0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  25.4 KiB │  25.4 KiB │    0 B 
      res │ 910.2 KiB │ 910.2 KiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │   2.9 MiB │   2.9 MiB │  +26 B │   2.9 MiB │   2.9 MiB │  +26 B 
    other │ 194.3 KiB │ 194.3 KiB │   +2 B │ 424.7 KiB │ 424.7 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.7 MiB │  12.7 MiB │ +502 B │  21.6 MiB │  21.6 MiB │ +394 B 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 43123 │ 43125 │ +2 (+3 -1)   
   types │ 14773 │ 14773 │  0 (+0 -0)   
 classes │ 12471 │ 12471 │  0 (+0 -0)   
 methods │ 61105 │ 61107 │ +2 (+10 -8)  
  fields │ 40315 │ 40319 │ +4 (+16 -12) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6031 │ 6031 │  0

APK

    compressed     │    uncompressed    │                               
──────────┬────────┼───────────┬────────┤                               
 size     │ diff   │ size      │ diff   │ path                          
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.9 MiB │ +474 B │   8.6 MiB │ +368 B │ ∆ classes.dex                 
  7.4 KiB │  +26 B │   7.2 KiB │  +26 B │ ∆ assets/dexopt/baseline.prof 
 52.8 KiB │   +3 B │ 116.9 KiB │    0 B │ ∆ META-INF/CERT.SF            
 49.5 KiB │   -2 B │ 116.8 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
  1.2 KiB │   +1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
──────────┼────────┼───────────┼────────┼───────────────────────────────
    4 MiB │ +502 B │   8.8 MiB │ +394 B │ (total)

DEX

STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   43123 │ 43125 │ +2 (+3 -1) 
  
  + getOnBehalfOf
  + setOnBehalfOf
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:13403cf,r8-mode:full,version:8.3.37}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:c5ba34a,r8-mode:full,version:8.3.37}
  

METHODS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   61105 │ 61107 │ +2 (+10 -8) 
  
  + com.stripe.android.view.CardMultilineWidget getOnBehalfOf() → String
  + com.stripe.android.view.CardMultilineWidget setOnBehalfOf(String)
  + m8.p0 create(Class) → w0
  + m8.p0 create(Class, c) → w0
  + m8.q0 <init>(s0, e)
  + m8.q0 h(Object) → Object
  + m8.r0 F(Object, Object) → Object
  + m8.r0 f(Object, e) → e
  + m8.s0 <init>(h, W, o0)
  + s6.W F(m, Map, e) → Object
  
  - m8.p0 <init>(s0, e)
  - m8.p0 F(Object, Object) → Object
  - m8.p0 f(Object, e) → e
  - m8.p0 h(Object) → Object
  - m8.q0 create(Class) → w0
  - m8.q0 create(Class, c) → w0
  - m8.s0 <init>(h, W)
  - s6.W F(m, e) → Object
  

FIELDS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   40315 │ 40319 │ +4 (+16 -12) 
  
  + com.stripe.android.view.CardMultilineWidget o0: String
  + com.stripe.android.view.CardMultilineWidget p0: boolean
  + com.stripe.android.view.CardMultilineWidget q0: d0
  + com.stripe.android.view.CardMultilineWidget r0: boolean
  + com.stripe.android.view.CardMultilineWidget v0: d0
  + com.stripe.android.view.CardMultilineWidget w0: g[]
  + m8.q0 U: Object
  + m8.q0 V: s0
  + m8.q0 W: int
  + m8.r0 V: o0
  + m8.r0 X: s0
  + m8.s0 c: x
  + m8.s0 d: o0
  + m8.s0 e: o0
  + m8.s0 f: o0
  + m8.s0 g: String
  
  - com.stripe.android.view.CardMultilineWidget o0: boolean
  - com.stripe.android.view.CardMultilineWidget p0: d0
  - com.stripe.android.view.CardMultilineWidget q0: boolean
  - com.stripe.android.view.CardMultilineWidget r0: d0
  - com.stripe.android.view.CardMultilineWidget v0: g[]
  - m8.p0 V: o0
  - m8.p0 W: int
  - m8.p0 X: s0
  - m8.r0 U: Object
  - m8.r0 V: s0
  - m8.s0 c: o0
  - m8.s0 d: o0

jaynewstrom-stripe · 2024-04-24T21:41:07Z

payments-core/src/main/java/com/stripe/android/view/CardWidgetViewModel.kt

 ) : ViewModel() {

 private val _isCbcEligible = MutableStateFlow(false)
 val isCbcEligible: StateFlow<Boolean> = _isCbcEligible
+ var onBehalfOf: String? = null


We should set this in savedStateHandle too.

samer-stripe · 2024-04-25T18:54:20Z

payments-core/src/test/java/com/stripe/android/view/CardWidgetViewModelTest.kt

@@ -61,6 +64,7 @@ class CardWidgetViewModelTest {
 paymentConfigProvider = { paymentConfig },
 stripeRepository = stripeRepository,
 dispatcher = testDispatcher,
+ handle = SavedStateHandle()
 )


Can we add a test to ensure it's saving to the handle?

jaynewstrom-stripe

Please link the API review.

jaynewstrom-stripe

Could you add some tests for the new functionality?

CHANGELOG.md

Add ability to set on_behalf_of for CBC elements

186d113

Remove logs

de1b564

jaynewstrom-stripe reviewed Apr 24, 2024

View reviewed changes

Fix tests

9262921

tjclawson-stripe marked this pull request as ready for review April 25, 2024 18:25

tjclawson-stripe requested review from a team as code owners April 25, 2024 18:25

tjclawson-stripe requested a review from carlosmuvi-stripe April 25, 2024 18:25

Update CHANGELOG.md

953afb0

samer-stripe reviewed Apr 25, 2024

View reviewed changes

jaynewstrom-stripe requested changes Apr 25, 2024

View reviewed changes

tjclawson-stripe added 2 commits April 25, 2024 17:59

Add methods to baseline, formatting

f5eb18e

Add savedStateHandle test for CardWidgetViewModel

c93325b

tjclawson-stripe requested review from samer-stripe and jaynewstrom-stripe April 26, 2024 15:50

Remove setOnBehalfOf function, add onBehalfOf var

88f3031

jaynewstrom-stripe reviewed May 10, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

tjclawson-stripe requested a review from jaynewstrom-stripe May 10, 2024 19:01

samer-stripe previously approved these changes May 10, 2024

View reviewed changes

Add OBO tests

0b63abb

tjclawson-stripe dismissed samer-stripe’s stale review via 0b63abb May 14, 2024 22:53

tjclawson-stripe requested a review from samer-stripe May 14, 2024 22:55

tjclawson-stripe added 2 commits May 14, 2024 18:57

Update CHANGELOG.md

7fe8236

Remove unused imports

ecca68b

jaynewstrom-stripe approved these changes May 15, 2024

View reviewed changes

tjclawson-stripe merged commit fc8f499 into master May 15, 2024
15 checks passed

tjclawson-stripe deleted the tyler/mobilesdk-1969 branch May 15, 2024 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to set on_behalf_of for CBC elements #8344

Add ability to set on_behalf_of for CBC elements #8344

tjclawson-stripe commented Apr 24, 2024 •

edited

github-actions bot commented Apr 24, 2024 •

edited

jaynewstrom-stripe Apr 24, 2024

tjclawson-stripe Apr 25, 2024

samer-stripe Apr 25, 2024

tjclawson-stripe Apr 25, 2024

tjclawson-stripe Apr 25, 2024

jaynewstrom-stripe left a comment

jaynewstrom-stripe left a comment

Add ability to set on_behalf_of for CBC elements #8344

Add ability to set on_behalf_of for CBC elements #8344

Conversation

tjclawson-stripe commented Apr 24, 2024 • edited

Summary

Motivation

Testing

Changelog

github-actions bot commented Apr 24, 2024 • edited

jaynewstrom-stripe Apr 24, 2024

Choose a reason for hiding this comment

tjclawson-stripe Apr 25, 2024

Choose a reason for hiding this comment

samer-stripe Apr 25, 2024

Choose a reason for hiding this comment

tjclawson-stripe Apr 25, 2024

Choose a reason for hiding this comment

tjclawson-stripe Apr 25, 2024

Choose a reason for hiding this comment

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

tjclawson-stripe commented Apr 24, 2024 •

edited

github-actions bot commented Apr 24, 2024 •

edited