[FC] Unify sync API calls and add refetch strategy #8317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APK |
3 tasks
tillh-stripe
reviewed
May 9, 2024
| ) | ||
| } | ||
|
|
||
| sealed interface FetchCondition { | ||
| fun check(response: SynchronizeSessionResponse): Boolean |
There was a problem hiding this comment.
Nit: The naming doesn’t tell what the result indicates. Can we rename this to shouldForceRefresh or shouldLoadFromBackend or something like that?
This also makes it easier to understand at the call site:
cachedSync.takeUnless { shouldLoadFromBackend(it) }
Comment on lines
36
to
40
| data object IfMissing : FetchCondition { | ||
| override fun check(response: SynchronizeSessionResponse): Boolean { | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: Should we rename this NoFetch or something along those lines? The case itself doesn’t have any “reload if missing” logic in it.
| ): SynchronizeSessionResponse = mutex.withLock { | ||
| val financialConnectionsRequest = | ||
| synchronizeRequest( | ||
| return when (val cachedSync = cachedSynchronizeSessionResponse) { |
There was a problem hiding this comment.
Nit: We can make this a bit more succinct.
val cachedSync = cachedSynchronizeSessionResponse?.takeUnless(fetchCondition)
return cachedSync ?: synchronize(applicationId, clientSecret)
Comment on lines
234
to
235
| // TODO REMOVE BEFORE MERGING INTEGRATION BRANCH | ||
| "forced_authflow_version" to "v3", |
There was a problem hiding this comment.
Should we remove this now? 🤔
…muvi/unify-syncs # Conflicts: # financial-connections/src/test/java/com/stripe/android/financialconnections/features/success/SuccessViewModelTest.kt
tillh-stripe
approved these changes
May 9, 2024
| @@ -74,7 +74,7 @@ internal class SuccessViewModelTest { | |||
| activeAuthSession = ApiKeyFixtures.authorizationSession(), | |||
| activeInstitution = ApiKeyFixtures.institution() | |||
| ) | |||
| whenever(getCachedAccounts()).thenReturn(accounts.data) | |||
There was a problem hiding this comment.
Not necessary in this pull request, but a good illustration of why we want fakes instead of mocks. We should get in the habit of modeling our use cases as interfaces and then injecting a fake in the test with some hard-coded data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've many sync calls / usecases and it's usually confusing to decide which to use. Additionally, there's situations where we want to force a refresh, even if there's a sync response cached, when certain conditions apply.
SynchronizeFinancialConnectionsSessionGetOrFetchSync(fetch = Always)GetManifestGetOrFetchSync().manifestAlso adds an expandable system to add re-fetch conditions. Added a
MissingActiveAuthSessioncondition that will attempt a refresh when retrieving the sync object inPartnerAuthif the auth session does not exist in the local sync response.Motivation
Testing
Screenshots
Changelog