Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detaching payment method test in CustomerSheetTest #8279

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

Summary

Add detaching payment method test in CustomerSheetTest

Motivation

Tests detaching payment method logic in CustomerSheet

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │   +265 B │   8.5 MiB │   8.5 MiB │    +88 B 
     arsc │   2.2 MiB │   2.2 MiB │      0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │     5 KiB │     5 KiB │      0 B │  24.9 KiB │  24.9 KiB │      0 B 
      res │ 907.5 KiB │ 907.5 KiB │      0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │ +1.4 KiB │     3 MiB │     3 MiB │ +1.4 KiB 
    other │ 203.7 KiB │ 203.7 KiB │     -7 B │ 444.2 KiB │ 444.2 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │ +1.6 KiB │  21.6 MiB │  21.7 MiB │ +1.5 KiB 

 DEX     │ old   │ new   │ diff        
─────────┼───────┼───────┼─────────────
   files │     1 │     1 │  0          
 strings │ 42624 │ 42624 │  0 (+2 -2)  
   types │ 14489 │ 14489 │  0 (+0 -0)  
 classes │ 12217 │ 12217 │  0 (+0 -0)  
 methods │ 60384 │ 60385 │ +1 (+10 -9) 
  fields │ 40050 │ 40050 │  0 (+2 -2)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6027 │ 6027 │  0
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  7.3 KiB │ +1.4 KiB │   7.2 KiB │ +1.4 KiB │ ∆ assets/dexopt/baseline.prof 
  3.9 MiB │   +265 B │   8.5 MiB │    +88 B │ ∆ classes.dex                 
 61.8 KiB │     -4 B │ 139.4 KiB │      0 B │ ∆ META-INF/CERT.SF            
  1.2 KiB │     -2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
   53 KiB │     -1 B │ 139.3 KiB │      0 B │ ∆ META-INF/MANIFEST.MF        
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
    4 MiB │ +1.6 KiB │   8.8 MiB │ +1.5 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42624 │ 42624 │ 0 (+2 -2) 
  
  + PaymentSheetEditButton
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:e4698b4,r8-mode:full,version:8.3.37}
  
  - VLLLZLLL
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:9d5a137,r8-mode:full,version:8.3.37}
  

METHODS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   60384 │ 60385 │ +1 (+10 -9) 
  
  + J8.n <init>(int, Object, boolean)
  + P0.s <init>(int, Object, boolean)
  + P0.s <init>(c, boolean)
  + V.S0 <init>(a, String, boolean)
  + V.S <init>(int, Object, boolean)
  + W7.Y1 <init>(String, a, a, String, boolean, String, String)
  + b.f <init>(int, Object, boolean)
  + e0.n0 q(int, l, boolean) → b
  + t.s <init>(int, Object, boolean)
  + w9.a <init>(int, Object)
  
  - J8.n <init>(Object, boolean, int)
  - P0.s <init>(Object, boolean, int)
  - P0.s <init>(boolean, Object, int)
  - V.S <init>(boolean, Object, int)
  - W7.Y1 <init>(String, a, a, boolean, String, String, String)
  - b.f <init>(boolean, Object, int)
  - e0.n0 q(l, boolean, int) → b
  - t.s <init>(Object, boolean, int)
  - w9.a <init>(Object, int)
  

FIELDS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   40050 │ 40050 │ 0 (+2 -2) 
  
  + W7.Y1 V: String
  + W7.Y1 W: boolean
  
  - W7.Y1 V: boolean
  - W7.Y1 W: String

@samer-stripe samer-stripe force-pushed the samer/add-customer-sheet-detach-test branch from e4979af to 3465433 Compare April 16, 2024 15:37
@samer-stripe samer-stripe enabled auto-merge (squash) April 16, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants