New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store encoded request to disk when using WorkManager #8269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
DEX
|
tillh-stripe
force-pushed
the
tillh/work-manager-fix
branch
2 times, most recently
from
April 15, 2024 14:43
ec39c34
to
4d30422
Compare
tillh-stripe
force-pushed
the
tillh/work-manager-fix
branch
2 times, most recently
from
May 16, 2024 16:47
6a4e414
to
39a4975
Compare
tillh-stripe
force-pushed
the
tillh/work-manager-fix
branch
from
May 16, 2024 16:48
39a4975
to
14e9a8c
Compare
carlosmuvi-stripe
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue with our WorkManager integration where we tried to serialize very large request objects. Now, we store these objects on disk and retrieve them in our worker via ID.
Motivation
Testing
Screenshots
Changelog