Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra phone number length validation for link inline signup #8266

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amk-stripe
Copy link
Contributor

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │   3.9 MiB │   3.9 MiB │ -279 B │   8.5 MiB │   8.5 MiB │ +24 B 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │   0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  24.9 KiB │  24.9 KiB │   0 B 
      res │ 911.1 KiB │ 911.1 KiB │    0 B │   1.4 MiB │   1.4 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │   0 B 
    asset │     3 MiB │     3 MiB │    0 B │     3 MiB │     3 MiB │   0 B 
    other │   204 KiB │   204 KiB │   +2 B │ 444.8 KiB │ 444.8 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │  12.8 MiB │  12.8 MiB │ -277 B │  21.7 MiB │  21.7 MiB │ +24 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42605 │ 42605 │ 0 (+1 -1) 
   types │ 14495 │ 14495 │ 0 (+0 -0) 
 classes │ 12223 │ 12223 │ 0 (+0 -0) 
 methods │ 60396 │ 60396 │ 0 (+0 -0) 
  fields │ 40086 │ 40086 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6030 │ 6030 │  0
APK
    compressed     │   uncompressed    │                        
──────────┬────────┼───────────┬───────┤                        
 size     │ diff   │ size      │ diff  │ path                   
──────────┼────────┼───────────┼───────┼────────────────────────
  3.9 MiB │ -279 B │   8.5 MiB │ +24 B │ ∆ classes.dex          
   62 KiB │   +6 B │ 139.7 KiB │   0 B │ ∆ META-INF/CERT.SF     
 53.1 KiB │   -4 B │ 139.6 KiB │   0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼────────┼───────────┼───────┼────────────────────────
    4 MiB │ -277 B │   8.8 MiB │ +24 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42605 │ 42605 │ 0 (+1 -1) 
  
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:8a83e73,r8-mode:full,version:8.3.37}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:3c16195,r8-mode:full,version:8.3.37}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant