Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process death handling in success screen #8198

Closed
wants to merge 2 commits into from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Apr 3, 2024

Summary

This pull request fixes an issue in the success screen that occurred on process death: Because the cachedAccounts weren’t persisted to disc, the retrieval upon process restoration failed.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.2 MiB │   4.2 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
    other │  99.8 KiB │  99.8 KiB │ +6 B │ 206.8 KiB │ 206.8 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.3 MiB │  12.3 MiB │ +6 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21470 │ 21470 │ 0 (+0 -0) 
   types │  6645 │  6645 │ 0 (+0 -0) 
 classes │  5411 │  5411 │ 0 (+0 -0) 
 methods │ 31009 │ 31009 │ 0 (+0 -0) 
  fields │ 18100 │ 18100 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 38.2 KiB │ +6 B │  86.7 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ +2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 29.5 KiB │ -2 B │  86.6 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
 68.9 KiB │ +6 B │ 174.5 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe force-pushed the tillh/fix-success-screen-process-death branch from fa0b09d to de4cf3a Compare April 3, 2024 03:09
@tillh-stripe tillh-stripe marked this pull request as ready for review April 3, 2024 03:23
@tillh-stripe tillh-stripe requested review from a team as code owners April 3, 2024 03:23
@tillh-stripe tillh-stripe marked this pull request as draft April 3, 2024 17:10
Base automatically changed from tillh/persisting-repo-fix to master April 3, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant