Fix sample projects, remove unused properties #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryptos-FR
reviewed
Mar 31, 2024
samples/Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj
Outdated
Show resolved
Hide resolved
| <DebugSymbols>true</DebugSymbols> | ||
| <DebugType>full</DebugType> | ||
| <Optimize>false</Optimize> | ||
| <DefineConstants>DEBUG;TRACE;STRIDE_PLATFORM_WINDOWS;STRIDE_PLATFORM_WINDOWS_DESKTOP</DefineConstants> |
There was a problem hiding this comment.
Are we sure the Stride constants don't need to be set?
There was a problem hiding this comment.
It seems that these constants do not exists anywhere in source code except in props file here https://github.com/stride3d/stride/blob/master/sources/targets/Stride.Core.props#L44, but in the end it has no affect on the app behavior at all
There was a problem hiding this comment.
@xen2 are they really unused, or could they be used by TeamCity tests for categorization?
They are not set on projects created by users, so the only candidate I can think of would be for testing. If not, let's remove them indeed.
samples/Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Current samples are using incorrect net8 target framework moniker (windows 7 is no longer supported). I also decided to remove additional bloat from project files
Types of changes
Checklist