Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix assemblyprocessor error if snk is specified #2118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itn3000
Copy link

@itn3000 itn3000 commented Jan 22, 2024

Stride.Core.AssemblyProcessor takes --delete-output-on-error option, but --delete-on-error in Stride.Core.targets file

PR Details

Fix build error when "AssemblyOriginatorKeyFile" property is used in project.

Description

This will fix Stride.Core.AssemblyProcessor command error executed in Stride.Core.targets.

Related Issue

#2117

Motivation and Context

I want to try to create R3(https://github.com/CySharp/R3) extension for Stride.
I tried to merge my source to upstream, but R3 project is using signing key.
So my source cannot be merge into upstream because of this error.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

Stride.Core.AssemblyProcessor takes `--delete-output-on-error` option, but `--delete-on-error` in Stride.Core.targets file
@Kryptos-FR
Copy link
Member

It's a breaking change since the parameter is different on both side. Wondering which one should be fixed (either the .targets file or the AssemblyProcessor code), or whether it matters.

Maybe .targets is better (as done here in the PR) since it means no need to recompile the AssemblyProcessor (and pushing it as binary).

@Eideren Eideren requested a review from xen2 April 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants