Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line wrapping to st code #8558

Closed

Conversation

sfc-gh-tteixeira
Copy link
Contributor

Describe your changes

Add st.code(..., wrap_lines=True|False). Defaults to False so there's no change in behavior.

GitHub Issue Link (if applicable)

n/a

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests - Will add as soon as I figure out PlayWright!
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Copy link
Collaborator

@vdonato vdonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- looks like snapshots just need to be updated so that playwright tests pass

@sfc-gh-tteixeira
Copy link
Contributor Author

I just noticed there's a bug when both wrapping and line numbers are set to True. Will look into it, and make a test.

Copy link

github-actions bot commented May 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 9, 2024
@github-actions github-actions bot closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants