Add miscellaneous small changes

e2e_playwright/st_set_page_config_icon.py

@@ -12,13 +12,15 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from pathlib import Path
+import os
 
 import streamlit as st
 
-icon_path = Path(__file__).parent.parent.joinpath("assets/favicon.ico")
-if not icon_path.is_file():
- print(f"Missing favicon at {str(icon_path)}")
- exit(1)
+# Construct test assets path relative to this script file to
+# allow its execution with different working directories.
+TEST_ASSETS_DIR = os.path.join(
+ os.path.dirname(os.path.abspath(__file__)), "test_assets"
+)
+ICON_PATH = os.path.join(TEST_ASSETS_DIR, "favicon.ico")
 
-st.set_page_config(page_icon=str(icon_path))
+st.set_page_config(page_icon=str(ICON_PATH))

frontend/lib/src/util/UriUtil.test.ts

@@ -184,7 +184,7 @@ describe("isValidOrigin", () => {
  expect(
  isValidOrigin(
  "http://localhost",
- // Example of localhost url used by Cypress
+ // Example of localhost url used by e2e test
  "http://localhost:35475"
  )
  ).toBeTruthy()

frontend/lib/src/util/UriUtil.ts

@@ -161,7 +161,7 @@ export function isValidOrigin(
  }
 
  // Allow localhost w/ any port for testing of host <-> guest communication
- // using hostframe.html (facilitates manual & Cypress e2e testing)
+ // using hostframe.html (facilitates manual & e2e testing)
  if (
  allowedUrl.protocol !== testUrl.protocol ||
  (allowedUrl.port !== testUrl.port && testUrl.hostname !== "localhost")

lib/streamlit/elements/empty.py

@@ -25,6 +25,7 @@
 
 
 class EmptyMixin:
+ @gather_metrics("empty")
  def empty(self) -> DeltaGenerator:
  """Insert a single-element container.
 

lib/streamlit/runtime/metrics_util.py

@@ -121,6 +121,10 @@
  "litellm",
  "comet_llm",
  "instructor",
+ "xgboost",
+ "lightgbm",
+ "catboost",
+ "sklearn",
  # Workflow Tools:
  "prefect",
  "luigi",

lib/tests/streamlit/elements/map_test.py

@@ -57,19 +57,23 @@ def test_basic(self):
  self.assertEqual(c.get("initialViewState").get("pitch"), 0)
  self.assertEqual(c.get("layers")[0].get("@@type"), "ScatterplotLayer")
 
- @parameterized.expand(
- itertools.product(
+ def test_alternative_names_columns(self):
+ """Test that it can be called with alternative names of lat/lon columns."""
+ name_combination = itertools.product(
  {"lat", "latitude", "LAT", "LATITUDE"},
  {"lon", "longitude", "LON", "LONGITUDE"},
  )
- )
- def test_alternative_names_columns(self, lat_column_name, lon_column_name):
- """Test that it can be called with alternative names of lat/lon columns."""
- df = mock_df.rename(columns={"lat": lat_column_name, "lon": lon_column_name})
- st.map(df)
 
- c = json.loads(self.get_delta_from_queue().new_element.deck_gl_json_chart.json)
- self.assertEqual(len(c.get("layers")[0].get("data")), 4)
+ for lat_column_name, lon_column_name in name_combination:
+ df = mock_df.rename(
+ columns={"lat": lat_column_name, "lon": lon_column_name}
+ )
+ st.map(df)
+
+ c = json.loads(
+ self.get_delta_from_queue().new_element.deck_gl_json_chart.json
+ )
+ self.assertEqual(len(c.get("layers")[0].get("data")), 4)
 
  def test_map_uses_convert_anything_to_df(self):
  """Test that st.map uses convert_anything_to_df to convert input data."""

lib/tests/streamlit/runtime/metrics_util_test.py

@@ -272,9 +272,7 @@ def test_public_api_commands(self):
  "connection",
  "experimental_connection",
  "spinner",
- "empty",
  "progress",
- "get_option",
  }
 
  # Create a list of all public API names in the `st` module (minus

proto/streamlit/proto/Arrow.proto

@@ -24,9 +24,9 @@ message Arrow {
  bytes data = 1;
  // Pandas styler information
  Styler styler = 2;
- // Width in CSS points
+ // Width in pixels
  uint32 width = 3;
- // Height in CSS points
+ // Height in pixels
  uint32 height = 4;
  // If True, will overwrite the dataframe width to fit to container.
  bool use_container_width = 5;

proto/streamlit/proto/ForwardMsg.proto

@@ -121,9 +121,9 @@ message ForwardMsgMetadata {
 // DEPRECATED: This is not used anymore.
 // Specifies the dimensions for the element
 message ElementDimensionSpec {
- // width in CSS points
+ // width in pixels
  uint32 width = 1;
 
- // height in CSS points
+ // height in pixels
  uint32 height = 2;
 }

proto/streamlit/proto/Skeleton.proto

@@ -28,6 +28,6 @@ message Skeleton {
  // Skeleton visual style
  SkeletonStyle style = 1;
 
- // Height in CSS points
+ // Height in pixels
  optional int32 height = 2;
 }