Add hint when add rows is used on vega lite chart #8499
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We have a lightweight check that's supposed to detect whether the data is a subset of the original data that checks the first and last value of the set, which creates some less than intended consequences (see issue). This change essentially handles the two use cases:
We fix this by adding an add_rows hint that we set only on the frontend. We use the hint to do the lightweight check and update the data.
This needs more testing but it looks like the unintended consequences include the fact that rerenders of the graph with superset data (not via
add_rows
) will rerender the whole graph (which feels fine).GitHub Issue Link (if applicable)
Closes #6689
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.