Add support for selections to st.altair_chart & st.vega_lite_chart
#8302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhuang1997
added
feature:charts
willhuang1997
requested review from
vdonato,
LukasMasuch and
sfc-gh-mnowotka
as code owners
willhuang1997
commented
Apr 4, 2024
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Outdated
Show resolved
Hide resolved
willhuang1997
commented
Apr 5, 2024
sfc-gh-wihuang
changed the base branch from
feature/InteractiveCharts_Plotly
to
develop
sfc-gh-wihuang
changed the base branch from
develop
to
feature/InteractiveCharts_Plotly
raethlein
reviewed
May 14, 2024
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Show resolved
Hide resolved
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Show resolved
Hide resolved
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx
Show resolved
Hide resolved
raethlein
approved these changes
May 14, 2024
LukasMasuch
approved these changes
May 14, 2024
sfc-gh-lmasuch
approved these changes
May 14, 2024
LukasMasuch
changed the title
st.altair_chart & st.vega_lite_chartst.altair_chart & st.vega_lite_chart
LukasMasuch
reviewed
May 14, 2024
| @@ -236,7 +236,7 @@ def _test_shift_click_point_selection_scatter_chart_displays_selection( | |||
| app.wait_for_timeout(100) | |||
|
|
|||
| expected_prefix = "Scatter chart with selection_point:" | |||
| expected_selection = "\\{'select': \\{'param_1': \\[\\{'Origin': 'USA', 'Horsepower': 88, 'Miles_per_Gallon': 20\\.2\\}, \\{'Origin': 'USA', 'Horsepower': 110, 'Miles_per_Gallon': 18\\.6\\}, \\{'Origin': 'USA', 'Horsepower': 150, 'Miles_per_Gallon': 14\\}, \\{'Origin': 'Japan', 'Horsepower': 52, 'Miles_per_Gallon': 32\\.8\\}\\]\\}\\}" | |||
| expected_selection = "\\{'select': \\{'param_1': \\[\\{'Origin': 'USA', 'Horsepower': (88|90), 'Miles_per_Gallon': 20\\.2\\}, \\{'Origin': 'USA', 'Horsepower': 110, 'Miles_per_Gallon': 18\\.6\\}, \\{'Origin': 'USA', 'Horsepower': 150, 'Miles_per_Gallon': 1(4|5)\\}, \\{'Origin': 'Japan', 'Horsepower': 52, 'Miles_per_Gallon': 32\\.8\\}\\]\\}\\}" | |||
There was a problem hiding this comment.
@raethlein We could also just check if there is any number in the value. I think for the test it doesn't really matter what kind of number is in there ... we just want to make sure that selecting an area works and returns an area selection.
Changes to the vega rendering might also easily apply small rendering changes so that the same selection leads to slightly different areas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds selection support to
st.altair_chartandst.vega_lite_chartthat can be used via:GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.