Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose fragments as a property on Info #3282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cpd67
Copy link

@cpd67 cpd67 commented Dec 6, 2023

Description

This PR adds a new fragments property to Info, which lets you access which fragments were queried for without having to go through _raw_info.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented Dec 6, 2023

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Exposes fragments as a property on Info, which lets you access queried fragments without having to go through _raw_info.

Here's the tweet text:

🆕 Release (next) is out! Thanks to Chris Dilley for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #3282 (efc51b5) into main (6b84220) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head efc51b5 differs from pull request most recent head ca18049. Consider uploading reports for the commit ca18049 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3282   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         482      482           
  Lines       29957    29961    +4     
  Branches     3694     3694           
=======================================
+ Hits        28936    28940    +4     
  Misses        835      835           
  Partials      186      186           

Copy link

codspeed-hq bot commented Dec 7, 2023

CodSpeed Performance Report

Merging #3282 will not alter performance

Comparing cpd67:feature/fragments-on-info (efc51b5) with main (6b84220)

Summary

✅ 11 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants