[3276] Fix incorrect template rendering

RELEASE.md

@@ -0,0 +1,3 @@
+Release type: patch
+
+This release addresses an issue in Django's GraphQLView. Previously, variables were consumed too early when overriding the template, leading to a syntax error in the JavaScript code.

strawberry/django/views.py

@@ -18,7 +18,7 @@
 from django.http.response import HttpResponse
 from django.template import RequestContext, Template
 from django.template.exceptions import TemplateDoesNotExist
-from django.template.loader import render_to_string
+from django.template.loader import get_template
 from django.template.response import TemplateResponse
 from django.utils.decorators import classonlymethod, method_decorator
 from django.views.decorators.csrf import csrf_exempt
@@ -218,7 +218,7 @@ def dispatch(
 
  def render_graphql_ide(self, request: HttpRequest) -> HttpResponse:
  try:
- template = Template(render_to_string("graphql/graphiql.html"))
+ template = get_template("graphql/graphiql.html").template
  except TemplateDoesNotExist:
  template = Template(self.graphql_ide_html)
 
@@ -277,7 +277,7 @@ async def dispatch( # pyright: ignore
 
  async def render_graphql_ide(self, request: HttpRequest) -> HttpResponse:
  try:
- template = Template(render_to_string("graphql/graphiql.html"))
+ template = get_template("graphql/graphiql.html").template
  except TemplateDoesNotExist:
  template = Template(self.graphql_ide_html)
 

tests/django/templates/graphql/graphiql.html

@@ -0,0 +1 @@
+<script>JSON.parse("{{ SUBSCRIPTION_ENABLED }}")</script>

tests/django/test_views.py

@@ -0,0 +1,28 @@
+from pathlib import Path
+
+from django.http import HttpResponse
+from django.test import Client, override_settings
+
+BASE_DIR = Path(__file__).parent
+TEMPLATES = [
+ {
+ "BACKEND": "django.template.backends.django.DjangoTemplates",
+ "DIRS": [BASE_DIR / "templates"],
+ "APP_DIRS": True,
+ }
+]
+
+
+def run_sync_view():
+ client = Client()
+ response: HttpResponse = client.get("/graphql/", HTTP_ACCEPT="text/html")
+ assert 'JSON.parse("false")' in response.content.decode()
+
+
+def test_render_graphiql_template():
+ run_sync_view()
+
+
+@override_settings(TEMPLATES=TEMPLATES)
+def test_subscription_enabled_not_empty():
+ run_sync_view()