Added section for Choice fields in documentation for types #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Enums example for Integer choices
for more information, see https://pre-commit.ci
bellini666
requested changes
Jan 14, 2023
Comment on lines
+37
to
+41
| @strawberry.enum | ||
| class FruitColor(Enum): | ||
| Red = 1 | ||
| Yellow = 2 | ||
| Green = 3 |
There was a problem hiding this comment.
Since IntegerChoices is an enum itself, this can probably be simplified to:
Suggested change
| @strawberry.enum | |
| class FruitColor(Enum): | |
| Red = 1 | |
| Yellow = 2 | |
| Green = 3 | |
| FruitColor = strawberry.enum(models.FruitColor, name="FruitColor") |
Maybe mention the two cases?
There was a problem hiding this comment.
Not to mention that the enum itself in the models.py module can be decorated and used directly by both django and strawberry
|
|
||
| ```python | ||
| # models.py | ||
| class FruitColor(models.IntegerChoices): |
There was a problem hiding this comment.
Maybe add an example for TextChoices as well?
|
This has not have any activity for a while now so I'm closing this to clean up the backlog a little. In case op or anyone wants to get back to this, feel free to reopen, or ask me to reopen in case you don't have permission to :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Enums example for Integer choices
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist