Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename core packages #20243

Merged
merged 9 commits into from May 2, 2024
Merged

chore: rename core packages #20243

merged 9 commits into from May 2, 2024

Conversation

remidej
Copy link
Contributor

@remidej remidej commented May 2, 2024

What does it do?

Renames the packages that were "core plugins" in v4, that are now core packages, so that they no longer have plugin- in their name. Those are the CM, CTB, email, upload and i18n.

@remidej remidej added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels May 2, 2024
@remidej remidej self-assigned this May 2, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this needs to be kept as the old name because people won't have installed the new version :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 0:48am

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from seconding Josh's comment that we want to leave the codemod alone, and some linting errors that your imports are out of alphabetical order now :)

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, do we need to release these packages manually to avoid NPM errors with them not being public? 🤔 might wanna talk to @alexandrebodin or @Marc-Roig first to double check that plan...

@remidej
Copy link
Contributor Author

remidej commented May 2, 2024

@joshuaellis yes I checked with Alex, he needs to do some manual steps before publication, so it won't be in today's release

@remidej remidej merged commit f1dbaef into v5/main May 2, 2024
80 of 84 checks passed
@remidej remidej deleted the chore/rename-core-packages branch May 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants