Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: moved cms components from DS to admin #20242

Merged
merged 2 commits into from May 6, 2024
Merged

chore: moved cms components from DS to admin #20242

merged 2 commits into from May 6, 2024

Conversation

madhurisandbhor
Copy link
Contributor

@madhurisandbhor madhurisandbhor commented May 2, 2024 •
edited by joshuaellis

What does it do?

  • Removed CMS specific components

Why is it needed?

  • With new design system V2, we are moving any specific CMS specific component to its own package as DS expands to cloud as well.

How to test it?

  • Everything (layouts) should look as it used to be

Related issue(s)/PR(s)

@madhurisandbhor madhurisandbhor added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels May 2, 2024
@madhurisandbhor madhurisandbhor self-assigned this May 2, 2024
@vercel Vercel
Copy link

vercel bot commented May 2, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 2:46pm

joshuaellis
joshuaellis reviewed May 2, 2024
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but overall looks fine.

Whats your thoughts on the API surface? we're exporting 3/4 XXXXLayout components, would it better to just export an object of Layouts? Should we be adding this to the Page component we have instead? 🤔

packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx Outdated Show resolved Hide resolved
packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx Outdated Show resolved Hide resolved
packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx Outdated Show resolved Hide resolved
packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx Outdated Show resolved Hide resolved
packages/core/admin/admin/src/components/Layout/GridLayout.tsx Outdated Show resolved Hide resolved
@madhurisandbhor madhurisandbhor marked this pull request as ready for review May 3, 2024 11:14
@joshuaellis joshuaellis force-pushed the chore/cms-components-from-DS branch from b249765 to d50e43b Compare May 3, 2024 14:25
@joshuaellis joshuaellis force-pushed the chore/cms-components-from-DS branch from d50e43b to 1832fb7 Compare May 3, 2024 14:35
joshuaellis
joshuaellis approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac Always GIF

@joshuaellis joshuaellis merged commit 63d7007 into v5/main May 6, 2024
80 of 83 checks passed
@joshuaellis joshuaellis deleted the chore/cms-components-from-DS branch May 6, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees

@madhurisandbhor madhurisandbhor

Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madhurisandbhor @joshuaellis