Fix flaky unit test for the CMReleasesContainer component #20233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
simotae14
changed the title
markkaylor
reviewed
Apr 30, 2024
| @@ -59,8 +59,10 @@ describe('CMReleasesContainer', () => { | |||
| it('should render the container', async () => { | |||
| render(); | |||
|
|
|||
| const informationBox = await screen.findByRole('complementary', { name: 'Releases' }); | |||
| expect(informationBox).toBeInTheDocument(); | |||
| await waitFor(async () => { | |||
There was a problem hiding this comment.
I think findBy queries already use a waitFor https://testing-library.com/docs/dom-testing-library/api-async#findby-queries. I think what you end up doing here with an additional waitFor is increase the timeout / retries. But It looks like you can pass waitFor options to the findBy query to do that as well.
There was a problem hiding this comment.
Mark is right, it'll also fail if it's not in the document. There's probably a different async fetch happening elsewhere that updates the component, you might needed to await something else.
|
Already fixed in #20250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I tried to find a way to fix the flaky unit test in the content releases
Why is it needed?
To pass the CI step