Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: refactor Dialog component to use radix primitive #1727

Merged
merged 2 commits into from
May 20, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • refactors Dialog to use the radix-ui primitive
  • exports helpful hooks like useMeasure, useControllableState, useId & useIsomorphicLayoutEffect

Related issue(s)/PR(s)

  • resolves DX-1293

@joshuaellis joshuaellis added pr: enhancement This PR adds or updates some part of the codebase or features source: design-system relates to design-system package labels May 20, 2024
@joshuaellis joshuaellis self-assigned this May 20, 2024
Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: 1497a46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/icons Major
@strapi/ui-primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 0:06am
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 0:06am
design-system-website 🛑 Canceled (Inspect) May 20, 2024 0:06am

Copy link

github-actions bot commented May 20, 2024

Size Change: +1.12 kB (+0.39%)

Total Size: 288 kB

Filename Size Change
packages/design-system/dist/index.js 94.4 kB +592 B (+0.63%)
packages/design-system/dist/index.mjs 93.2 kB +525 B (+0.57%)
ℹ️ View Unchanged
Filename Size
packages/icons/dist/index.js 22.1 kB
packages/icons/dist/index.mjs 21.7 kB
packages/icons/dist/symbols-index.js 11.9 kB
packages/icons/dist/symbols-index.mjs 11.8 kB
packages/primitives/dist/index.js 16.7 kB
packages/primitives/dist/index.mjs 16.3 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant