automatically strip play functions for react-native runtime #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Play functions are not supported on native. Instead of requiring consumers to guard their play functions with platform checks, we automatically strip any stories of their play functions for them.
How to test
This PR doesn't fully make writing play functions compatible with @storybook/react-native. See https://discord.com/channels/486522875931656193/490822534233849873/1233464353907540081.
I've worked around the build issue with the following metro config for now which is a bit hacky
I don't think it yet makes sense to add an example test showing that the play function is stripped from a story.
Please explain how to test your changes and consider the following questions.
If your answer is yes to any of these, please make sure to include it in your PR.