feat: page wait until load #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddyFromPoker
approved these changes
May 20, 2021
leonardlib
approved these changes
May 25, 2021
renchris
force-pushed
the
feat/page-navigation/cr
branch
from
28c1311
to
73f5ca4
Compare
steve-lopez
approved these changes
Aug 30, 2021
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: React-snap was failing with
TimeoutError: Navigation Timeout Exceeded: 30000ms exceededdue to a heavier UI process (ie. Hero Banner gradient flow animation).Change: Page navigation waits until load (ie. navigation to be finished when the load event is fired) instead of networkidle0 (ie. consider navigation to be finished when there are no more than 0 network connections for at least 500 ms).