Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node colours): Revisit the colour theming for nodes #2126

Open
simonwinter opened this issue Mar 13, 2024 · 1 comment
Open

fix(node colours): Revisit the colour theming for nodes #2126

simonwinter opened this issue Mar 13, 2024 · 1 comment
Assignees
Labels
module: web Related to web browser clients and interfaces type: design Design related issues type: feature Proposes a new feature

Comments

@simonwinter
Copy link
Collaborator

Summary

Currently we're relying on very generic tailwind colours to set our node background colours etc.

const nodeColours = (name: string) => ({
  colour: colours[name][100],
  borderColour: colours[name][200],
})

In general, the design requires more variation than this. We need to review the available design tokens.

Examples:

Note: I think there may be some colour mistakes here - black for block heading, incorrect purple on icon when not needed.

CleanShot 2024-03-14 at 12 05 07

CleanShot 2024-03-14 at 12 05 32

CleanShot 2024-03-14 at 12 05 58

@simonwinter simonwinter added type: feature Proposes a new feature module: web Related to web browser clients and interfaces type: design Design related issues labels Mar 13, 2024
@simonwinter simonwinter self-assigned this Mar 13, 2024
@nokome
Copy link
Member

nokome commented Mar 13, 2024

Yes, agreed. Someone needs to go through and finish populating the nodeTypeUIMap with specific colour and borderColour hex (?) colours. The nodeColours func was just an expedient gap filler until the final colors were chosen in the Figma designs.

Having said that, I'm not sure we have final colour choices and there are some inconsistencies in the latest designs (e.g. CodeChunk is a green, whereas its inline equivalent, a CodeExpression is a blue). So as part of this lets review all the colors used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: web Related to web browser clients and interfaces type: design Design related issues type: feature Proposes a new feature
Projects
Status: No status
Development

No branches or pull requests

2 participants