-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(<stencila-ui-node-execution-messages>
): improve rendering of messages as per designs
#2127
Comments
@simonwinter is this related to what you're doing at the moment? might need to hold off implementing this issue until that is wrapped up. |
@mike-parkin - yeah, it's definitely related. to #2124. Let's get that merged first. |
@mike-parkin when you get around to this, the pattern we've used to render the <stencila-collapsible-node-field
.collapsed=${false}
headerBg=${this.headerBg}
>
<div slot="title">Messages</div>
<div class="px-6 py-3 flex flex-col gap-y-3" slot="content">
...
</div>
</stencila-collapsible-node-field> I'd like to re-think the headerBG - this may be some style object we get from #2126. In my mind, I see this as a repeatable pattern ... though the use of |
@mike-parkin I've closed the wip PR so you can start this on top of the work @simonwinter has done. Can you please start a new PR off |
I suggest that we use the pattern that we have established with Then whichever components are in the hierarchy can use that to fetch whichever colours or icons they need from a function in |
Backgound
All node types derived from
Executable
have anexecutionMessages
property. We need to fix the rendering of these so that they match the designs closer. Currently they look like this:The designs look like this:
Tasks
<stencila-ui-node-execution-messages>
component, consistent with out approach of creating property-level components. This component will be the container for one or messages and have a counter for the number of messages at each level.<stencila-ui-node-execution-message>
to represent each individualExecutionMessage
with collapsable stack trace etc@mike-parkin I'm going to setup the new components in a new PR and then hand it over to you.
The text was updated successfully, but these errors were encountered: