Add support for edge features to GraphSAGE #1581
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
force-pushed
the
feature/1328-graphsage-edge-features
branch
from
75261df
to
3df8da4
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| # finished i-th walk from node so add it to the list of walks as a list | ||
| walks.append(walk) | ||
| if include_edges: | ||
| assert len(walk_edges) == len(walk) - 1 |
There was a problem hiding this comment.
Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
| if generator.use_edge_features: | ||
| edge_feature_sizes = generator.graph.edge_feature_sizes() | ||
| # the generator validates there's only one edge type | ||
| assert len(edge_feature_sizes) == 1 |
There was a problem hiding this comment.
Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
| ] | ||
| ) | ||
| # there's never an edge for the head node (i.e. first element), so don't include it | ||
| assert np.size(edge_features[0]) == 0 |
There was a problem hiding this comment.
Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
| for layer_nodes in nodes_per_hop | ||
| ] | ||
| # there's never an edge for the head node (i.e. first element), so don't include it | ||
| assert np.size(edge_features[0]) == 0 |
There was a problem hiding this comment.
Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
|
Code Climate has analyzed commit 3df8da4 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Any updates if this is going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a GraphSAGE generator to optionally include the features of edges that were traversed, and thus the model to factor these features into its predictions.
See: #1328