This should actually fix issue #351 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messages that turned out to not be guaranteed, this doesn't rely on such an order. Also removed SubclassSpinBox function and moved the code from that to be handled via the WM_PARENTNOTIFY message in RunProc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch I submitted wasn't intended to be "ready to commit". This seems to be solid as far as I have tested. It uses
GetWindowLongto determine whetherWS_VISIBLEis set for the spin control.The problem with the patch turned out to be that
WM_PAINTwas sent to theTabBar_Proc(and thusRunProc) beforeWM_PAINTwas sent toTabBarSpin_Proc.Also removed the
SubclassSpinBoxfunction and replaced it withWM_PARENTNOTIFYinRunProc.