Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update math/base/special/log10 to follow FreeBSD version 12.2.0 #2215

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

refactor: update math/base/special/log10 to follow FreeBSD version 12.2.0 #2215

wants to merge 4 commits into from
+79 −132

Conversation

gunjjoshi
Copy link
Contributor

@gunjjoshi gunjjoshi commented Apr 28, 2024 •
edited

Description

What is the purpose of this pull request?

This pull request:

  • updates existing JavaScript implementation to follow FreeBSD version 12.2.0.
  • adds a corresponding test.

Related Issues

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Code coverage report:
Screenshot 2024-04-28 at 09 29 44

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 28, 2024
@gunjjoshi gunjjoshi mentioned this pull request Apr 28, 2024
Merged
11 tasks
@Planeshifter Planeshifter self-requested a review May 29, 2024 00:43
@kgryte kgryte added the C Issue involves or relates to C. label May 29, 2024
Planeshifter
Planeshifter approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small comments with regards to the code comments, otherwise looks good to me!

@gunjjoshi
Copy link
Contributor Author

Left two small comments with regards to the code comments, otherwise looks good to me!

Thanks, I've made the changes in both main.c and main.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gunjjoshi @Planeshifter @kgryte @stdlib-bot